Implement tag name selector for FindElement and related WebDriver commands #23585

georgeroman · 2019-06-17T16:19:32Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors

There are tests for these changes

This change is

highfive · 2019-06-17T16:19:37Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/webdriver_handlers.rs, components/webdriver_server/lib.rs, components/script/script_thread.rs
@jgraham: components/webdriver_server/lib.rs
@KiChjang: components/script/webdriver_handlers.rs, components/script/script_thread.rs, components/script_traits/webdriver_msg.rs

jdm · 2019-06-17T17:05:16Z

@bors-servo r+

bors-servo · 2019-06-17T17:05:20Z

📌 Commit e2596e3 has been approved by jdm


        Auto merge of #23585 - georgeroman:tag_name_selector_for_find_element…

…_wd_commands, r=jdm Implement tag name selector for FindElement and related WebDriver commands  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors  - [X] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23585)

bors-servo · 2019-06-17T17:34:27Z

⌛ Testing commit e2596e3 with merge f3ce98a...

bors-servo · 2019-06-17T18:16:50Z

💔 Test failed - linux-rel-wpt

highfive · 2019-06-17T18:17:05Z

Test failures:

▶ Unexpected subtest result in /webdriver/tests/find_elements/find.py: │ FAIL [expected PASS] test_find_elements[css selector-#linkText] │ → assert 0 == 1 │ │ session = , using = 'css selector' │ value = '#linkText' │ │ @pytest.mark.parametrize("using,value", │ [("css selector", "#linkText"), │ ("link text", "full link text"), │ ("partial link text", "link text"), │ ("tag name", "a"), │ ("xpath", "//a")]) │ def test_find_elements(session, using, value): │ # Step 8 - 9 │ session.url = inline("full link text") │ │ response = find_elements(session, using, value) │ assert_success(response) │ > assert len(response.body["value"]) == 1 │ E assert 0 == 1 │ E + where 0 = len([]) │ │ response = │ session = │ using = 'css selector' │ value = '#linkText' │ └ tests/wpt/web-platform-tests/webdriver/tests/find_elements/find.py:52: AssertionError

  ▶ Unexpected subtest result in /webdriver/tests/find_elements/find.py:
  │ FAIL [expected PASS] test_find_elements[tag name-a]
  │   → assert 0 == 1
  │ 
  │ session = <Session b99bec99-4fdc-43dc-9d57-432e76a59156>, using = 'tag name'
  │ value = 'a'
  │ 
  │     @pytest.mark.parametrize("using,value",
  │                              [("css selector", "#linkText"),
  │                               ("link text", "full link text"),
  │                               ("partial link text", "link text"),
  │                               ("tag name", "a"),
  │                               ("xpath", "//a")])
  │     def test_find_elements(session, using, value):
  │         # Step 8 - 9
  │         session.url = inline("<a href=# id=linkText>full link text</a>")
  │     
  │         response = find_elements(session, using, value)
  │         assert_success(response)
  │ >       assert len(response.body["value"]) == 1
  │ E       assert 0 == 1
  │ E        +  where 0 = len([])
  │ 
  │ response   = <Responsetatus=200 body={"value": []}>
  │ session    = <Session b99bec99-4fdc-43dc-9d57-432e76a59156>
  │ using      = 'tag name'
  │ value      = 'a'
  │ 
  └ tests/wpt/web-platform-tests/webdriver/tests/find_elements/find.py:52: AssertionError

  ▶ Unexpected subtest result in /webdriver/tests/find_element_from_element/find.py:
  │ FAIL [expected PASS] test_find_element[css selector-#linkText]
  │   → AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ session = <Session fadbd0f1-8acf-4ef8-bab5-4ad5109b6a8a>, using = 'css selector'
  │ value = '#linkText'
  │ 
  │     @pytest.mark.parametrize("using,value",
  │                              [("css selector", "#linkText"),
  │                               ("link text", "full link text"),
  │                               ("partial link text", "link text"),
  │                               ("tag name", "a"),
  │                               ("xpath", "//a")])
  │     def test_find_element(session, using, value):
  │         # Step 8 - 9
  │         session.url = inline("<div><a href=# id=linkText>full link text</a></div>")
  │         element = session.find.css("div", all=False)
  │ >       response = find_element(session, element.id, using, value)
  │ E       AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ element    = None
  │ session    = <Session fadbd0f1-8acf-4ef8-bab5-4ad5109b6a8a>
  │ using      = 'css selector'
  │ value      = '#linkText'
  │ 
  └ tests/wpt/web-platform-tests/webdriver/tests/find_element_from_element/find.py:56: AttributeError

  ▶ Unexpected subtest result in /webdriver/tests/find_element_from_element/find.py:
  │ FAIL [expected PASS] test_find_element[tag name-a]
  │   → AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ session = <Session fadbd0f1-8acf-4ef8-bab5-4ad5109b6a8a>, using = 'tag name'
  │ value = 'a'
  │ 
  │     @pytest.mark.parametrize("using,value",
  │                              [("css selector", "#linkText"),
  │                               ("link text", "full link text"),
  │                               ("partial link text", "link text"),
  │                               ("tag name", "a"),
  │                               ("xpath", "//a")])
  │     def test_find_element(session, using, value):
  │         # Step 8 - 9
  │         session.url = inline("<div><a href=# id=linkText>full link text</a></div>")
  │         element = session.find.css("div", all=False)
  │ >       response = find_element(session, element.id, using, value)
  │ E       AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ element    = None
  │ session    = <Session fadbd0f1-8acf-4ef8-bab5-4ad5109b6a8a>
  │ using      = 'tag name'
  │ value      = 'a'
  │ 
  └ tests/wpt/web-platform-tests/webdriver/tests/find_element_from_element/find.py:56: AttributeError

  ▶ Unexpected subtest result in /webdriver/tests/find_element_from_element/find.py:
  │ FAIL [expected PASS] test_null_parameter_value
  │   → AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ session = <Session fadbd0f1-8acf-4ef8-bab5-4ad5109b6a8a>
  │ http = <tests.support.http_request.HTTPRequest object at 0x7f129101f610>
  │ 
  │     def test_null_parameter_value(session, http):
  │         session.url = inline("<div><a href=# id=linkText>full link text</a></div>")
  │         element = session.find.css("div", all=False)
  │     
  │         path = "/session/{session_id}/element/{element_id}/element".format(
  │ >           session_id=session.session_id, element_id=element.id)
  │ E       AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ element    = None
  │ http       = <tests.support.http_request.HTTPRequest object at 0x7f129101f610>
  │ session    = <Session fadbd0f1-8acf-4ef8-bab5-4ad5109b6a8a>
  │ 
  └ tests/wpt/web-platform-tests/webdriver/tests/find_element_from_element/find.py:22: AttributeError

  ▶ Unexpected subtest result in /webdriver/tests/find_elements_from_element/find.py:
  │ FAIL [expected PASS] test_find_elements[tag name-a]
  │   → AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ session = <Session 8e27bf6d-03f2-4d06-994d-ffc6bf4f4d74>, using = 'tag name'
  │ value = 'a'
  │ 
  │     @pytest.mark.parametrize("using,value",
  │                              [("css selector", "#linkText"),
  │                               ("link text", "full link text"),
  │                               ("partial link text", "link text"),
  │                               ("tag name", "a"),
  │                               ("xpath", "//a")])
  │     def test_find_elements(session, using, value):
  │         # Step 8 - 9
  │         session.url = inline("<div><a href=# id=linkText>full link text</a></div>")
  │         element = session.find.css("div", all=False)
  │ >       response = find_elements(session, element.id, using, value)
  │ E       AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ element    = None
  │ session    = <Session 8e27bf6d-03f2-4d06-994d-ffc6bf4f4d74>
  │ using      = 'tag name'
  │ value      = 'a'
  │ 
  └ tests/wpt/web-platform-tests/webdriver/tests/find_elements_from_element/find.py:56: AttributeError

  ▶ Unexpected subtest result in /webdriver/tests/find_elements_from_element/find.py:
  │ FAIL [expected PASS] test_no_element[css selector-#wontExist]
  │   → AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ session = <Session 8e27bf6d-03f2-4d06-994d-ffc6bf4f4d74>, using = 'css selector'
  │ value = '#wontExist'
  │ 
  │     @pytest.mark.parametrize("using,value", [("css selector", "#wontExist")])
  │     def test_no_element(session, using, value):
  │         # Step 8 - 9
  │         session.url = inline("<div></div>")
  │         element = session.find.css("div", all=False)
  │ >       response = find_elements(session, element.id, using, value)
  │ E       AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ element    = None
  │ session    = <Session 8e27bf6d-03f2-4d06-994d-ffc6bf4f4d74>
  │ using      = 'css selector'
  │ value      = '#wontExist'
  │ 
  └ tests/wpt/web-platform-tests/webdriver/tests/find_elements_from_element/find.py:112: AttributeError

  ▶ Unexpected subtest result in /webdriver/tests/find_elements_from_element/find.py:
  │ FAIL [expected PASS] test_find_elements[css selector-#linkText]
  │   → AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ session = <Session 8e27bf6d-03f2-4d06-994d-ffc6bf4f4d74>, using = 'css selector'
  │ value = '#linkText'
  │ 
  │     @pytest.mark.parametrize("using,value",
  │                              [("css selector", "#linkText"),
  │                               ("link text", "full link text"),
  │                               ("partial link text", "link text"),
  │                               ("tag name", "a"),
  │                               ("xpath", "//a")])
  │     def test_find_elements(session, using, value):
  │         # Step 8 - 9
  │         session.url = inline("<div><a href=# id=linkText>full link text</a></div>")
  │         element = session.find.css("div", all=False)
  │ >       response = find_elements(session, element.id, using, value)
  │ E       AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ element    = None
  │ session    = <Session 8e27bf6d-03f2-4d06-994d-ffc6bf4f4d74>
  │ using      = 'css selector'
  │ value      = '#linkText'
  │ 
  └ tests/wpt/web-platform-tests/webdriver/tests/find_elements_from_element/find.py:56: AttributeError

  ▶ Unexpected subtest result in /webdriver/tests/find_elements_from_element/find.py:
  │ FAIL [expected PASS] test_null_parameter_value
  │   → AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ session = <Session 8e27bf6d-03f2-4d06-994d-ffc6bf4f4d74>
  │ http = <tests.support.http_request.HTTPRequest object at 0x7f1281fdb150>
  │ 
  │     def test_null_parameter_value(session, http):
  │         session.url = inline("<div><a href=# id=linkText>full link text</a></div>")
  │         element = session.find.css("div", all=False)
  │     
  │         path = "/session/{session_id}/element/{element_id}/elements".format(
  │ >           session_id=session.session_id, element_id=element.id)
  │ E       AttributeError: 'NoneType' object has no attribute 'id'
  │ 
  │ element    = None
  │ http       = <tests.support.http_request.HTTPRequest object at 0x7f1281fdb150>
  │ session    = <Session 8e27bf6d-03f2-4d06-994d-ffc6bf4f4d74>
  │ 
  └ tests/wpt/web-platform-tests/webdriver/tests/find_elements_from_element/find.py:22: AttributeError

georgeroman · 2019-06-17T18:25:01Z

Hmm, this is weird, these tests are passing locally.

jdm · 2019-06-17T18:28:22Z

What operating system are you using?

georgeroman · 2019-06-17T18:31:05Z

I'm using Arch Linux.

jdm · 2019-07-04T19:22:41Z

@georgeroman What's the plan for this PR?

georgeroman · 2019-07-04T20:06:42Z

Once I'm finished with the current work on returning arrays and objects from ExecuteScript I will come back to it and dive deeper into what might cause the tests fail on the CI.

georgeroman · 2019-07-11T21:28:33Z

I rebased this, it will hopefully pass the tests now.

jdm · 2019-07-11T21:49:17Z

@bors-servo try=wpt

bors-servo · 2019-07-11T21:49:22Z

⌛ Trying commit 3deb1f3 with merge ce5b643...


        Auto merge of #23585 - georgeroman:tag_name_selector_for_find_element…

…_wd_commands, r=<try> Implement tag name selector for FindElement and related WebDriver commands  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors  - [X] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23585)

bors-servo · 2019-07-11T22:31:25Z

💔 Test failed - linux-rel-wpt

georgeroman · 2019-07-12T19:36:12Z

I suspect that something is going wrong with the way the fixture html files are provided:

servo/tests/wpt/web-platform-tests/webdriver/tests/find_elements/find.py

Line 48 in 812bf8d

session.url = inline("<a href=# id=linkText>full link text</a>")

Could I add some debug prints and then test them in the CI server?

jdm · 2019-07-12T19:38:20Z

Sure! Add yourself to https://github.com/servo/saltfs/blob/master/homu/files/cfg.toml so we can grant you access to do try runs when you need to.

georgeroman · 2019-07-18T22:54:05Z

@bors-servo try=wpt

bors-servo · 2019-07-18T22:54:10Z

⌛ Trying commit 03a0018 with merge 67cccdf...


        Auto merge of #23585 - georgeroman:tag_name_selector_for_find_element…

…_wd_commands, r=<try> Implement tag name selector for FindElement and related WebDriver commands  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors  - [X] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23585)

bors-servo · 2019-07-18T23:41:21Z

💔 Test failed - linux-rel-wpt

jdm · 2019-07-19T18:45:38Z

@bors-servo delegate+

bors-servo · 2019-07-19T18:45:39Z

✌️ @georgeroman can now approve this pull request

bors-servo · 2019-07-21T01:27:12Z

☔ The latest upstream changes (presumably #23808) made this pull request unmergeable. Please resolve the merge conflicts.


        Implement tag name selector for FindElement WebDriver command


        Implement tag name selector for FindElements WebDriver command


        Implement tag name selector for FindElementFromElement WebDriver command


        Implement tag name selector for FindElementsFromElement WebDriver com…

…mand

georgeroman · 2019-07-21T13:00:44Z

@bors-servo try=wpt

bors-servo · 2019-07-21T13:00:48Z

⌛ Trying commit bf6ea64 with merge 583ee37...


        Auto merge of #23585 - georgeroman:tag_name_selector_for_find_element…

…_wd_commands, r=<try> Implement tag name selector for FindElement and related WebDriver commands  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors  - [X] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23585)

bors-servo · 2019-07-21T13:43:25Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

jdm · 2019-07-21T13:44:23Z

@bors-servo r+

bors-servo · 2019-07-21T13:44:24Z

📌 Commit bf6ea64 has been approved by jdm

bors-servo · 2019-07-21T13:44:28Z

⌛ Testing commit bf6ea64 with merge 7527596...


        Auto merge of #23585 - georgeroman:tag_name_selector_for_find_element…

…_wd_commands, r=jdm Implement tag name selector for FindElement and related WebDriver commands  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors  - [X] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23585)

bors-servo · 2019-07-21T15:45:49Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 7527596 to master...

highfive assigned nox Jun 17, 2019

highfive added the S-awaiting-review label Jun 17, 2019

highfive assigned jdm and unassigned nox Jun 17, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jun 17, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 17, 2019

highfive added S-awaiting-review and removed S-tests-failed labels Jul 11, 2019

highfive added the S-tests-failed label Jul 11, 2019

highfive added the S-tests-failed label Jul 18, 2019

jdm removed the S-awaiting-review label Jul 19, 2019

highfive added the S-needs-rebase label Jul 21, 2019

georgeroman added 4 commits Jun 17, 2019

Implement tag name selector for FindElement WebDriver command

7d5b324

Implement tag name selector for FindElements WebDriver command

dec73e4

Implement tag name selector for FindElementFromElement WebDriver command

616a81f

Implement tag name selector for FindElementsFromElement WebDriver com…

Loading status checks…

bf6ea64

…mand

highfive added S-awaiting-review and removed S-tests-failed labels Jul 21, 2019

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Jul 21, 2019

bors-servo merged commit bf6ea64 into servo:master Jul 21, 2019
3 checks passed

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jul 21, 2019

servo / servo

Implement tag name selector for FindElement and related WebDriver commands #23585

Implement tag name selector for FindElement and related WebDriver commands #23585

georgeroman commented Jun 17, 2019 •

edited by SimonSapin

highfive commented Jun 17, 2019

jdm commented Jun 17, 2019

bors-servo commented Jun 17, 2019

bors-servo commented Jun 17, 2019

bors-servo commented Jun 17, 2019

highfive commented Jun 17, 2019

georgeroman commented Jun 17, 2019

jdm commented Jun 17, 2019

georgeroman commented Jun 17, 2019

jdm commented Jul 4, 2019

georgeroman commented Jul 4, 2019

georgeroman commented Jul 11, 2019

jdm commented Jul 11, 2019

bors-servo commented Jul 11, 2019

bors-servo commented Jul 11, 2019

georgeroman commented Jul 12, 2019

jdm commented Jul 12, 2019

georgeroman commented Jul 18, 2019

bors-servo commented Jul 18, 2019

bors-servo commented Jul 18, 2019

jdm commented Jul 19, 2019

bors-servo commented Jul 19, 2019

bors-servo commented Jul 21, 2019

georgeroman commented Jul 21, 2019

bors-servo commented Jul 21, 2019

bors-servo commented Jul 21, 2019

jdm commented Jul 21, 2019

bors-servo commented Jul 21, 2019

bors-servo commented Jul 21, 2019

bors-servo commented Jul 21, 2019

servo / servo

Join GitHub today

Implement tag name selector for FindElement and related WebDriver commands #23585

Implement tag name selector for FindElement and related WebDriver commands #23585

Conversation

georgeroman commented Jun 17, 2019 • edited by SimonSapin

highfive commented Jun 17, 2019

jdm commented Jun 17, 2019

bors-servo commented Jun 17, 2019

bors-servo commented Jun 17, 2019

bors-servo commented Jun 17, 2019

highfive commented Jun 17, 2019

georgeroman commented Jun 17, 2019

jdm commented Jun 17, 2019

georgeroman commented Jun 17, 2019

jdm commented Jul 4, 2019

georgeroman commented Jul 4, 2019

georgeroman commented Jul 11, 2019

jdm commented Jul 11, 2019

bors-servo commented Jul 11, 2019

bors-servo commented Jul 11, 2019

georgeroman commented Jul 12, 2019

jdm commented Jul 12, 2019

georgeroman commented Jul 18, 2019

bors-servo commented Jul 18, 2019

bors-servo commented Jul 18, 2019

jdm commented Jul 19, 2019

bors-servo commented Jul 19, 2019

bors-servo commented Jul 21, 2019

georgeroman commented Jul 21, 2019

bors-servo commented Jul 21, 2019

bors-servo commented Jul 21, 2019

jdm commented Jul 21, 2019

bors-servo commented Jul 21, 2019

bors-servo commented Jul 21, 2019

bors-servo commented Jul 21, 2019

georgeroman commented Jun 17, 2019 •

edited by SimonSapin