Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SpiderMonkey 67 #23587

Merged
merged 1 commit into from Jun 27, 2019
Merged

Upgrade to SpiderMonkey 67 #23587

merged 1 commit into from Jun 27, 2019

Conversation

@jdm
Copy link
Member

jdm commented Jun 17, 2019 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Jun 17, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/proxyhandler.rs, components/script/microtask.rs, components/script/dom/customelementregistry.rs, components/script/dom/globalscope.rs and 12 more
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/proxyhandler.rs, components/script/microtask.rs, components/script/dom/customelementregistry.rs, components/script/dom/globalscope.rs and 12 more
@highfive
Copy link

highfive commented Jun 17, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Jun 17, 2019

@bors-servo try
bors-servo added a commit that referenced this pull request Jun 17, 2019
@bors-servo
Auto merge of #23587 - jdm:smup67, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8b19502 
Upgrade to SpiderMonkey 67
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2019

⌛ Trying commit adc0465 with merge 8b19502...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member Author

jdm commented Jun 18, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Jun 18, 2019
@bors-servo
Auto merge of #23587 - jdm:smup67, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
87a0ae1 
Upgrade to SpiderMonkey 67

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23587)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2019

⌛ Trying commit 8aa6965 with merge 87a0ae1...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@jdm
Copy link
Member Author

jdm commented Jun 18, 2019

@bors-servo try
bors-servo added a commit that referenced this pull request Jun 18, 2019
@bors-servo
Auto merge of #23587 - jdm:smup67, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6fbcc6b 
Upgrade to SpiderMonkey 67

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23587)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2019

⌛ Trying commit 14aebe0 with merge 6fbcc6b...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jun 19, 2019

The mac homebrew failures are very mysterious and have been observed in other PRs as well.
@jdm
Copy link
Member Author

jdm commented Jun 20, 2019

@bors-servo try
@jdm
Copy link
Member Author

jdm commented Jun 20, 2019

@bors-servo retry
bors-servo added a commit that referenced this pull request Jun 20, 2019
@bors-servo
Auto merge of #23587 - jdm:smup67, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
60df6b1 
Upgrade to SpiderMonkey 67

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23587)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2019

⌛ Trying commit 14aebe0 with merge 60df6b1...
@jdm
Copy link
Member Author

jdm commented Jun 21, 2019

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2019

⌛ Trying commit 51712a5 with merge 58b0bec...
bors-servo added a commit that referenced this pull request Jun 21, 2019
@bors-servo
Auto merge of #23587 - jdm:smup67, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
58b0bec 
Upgrade to SpiderMonkey 67

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23587)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jun 26, 2019

@bors-servo try=linux
@bors-servo
Copy link
Contributor

bors-servo commented Jun 26, 2019

⌛ Trying commit 9b8532e with merge f03ff07...
bors-servo added a commit that referenced this pull request Jun 26, 2019
@bors-servo
Auto merge of #23587 - jdm:smup67, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f03ff07 
Upgrade to SpiderMonkey 67

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23587)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 26, 2019

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:smup67 branch from 9b8532e to 5071332 Jun 26, 2019
@jdm
Copy link
Member Author

jdm commented Jun 26, 2019

@bors-servo try=linux
@bors-servo
Copy link
Contributor

bors-servo commented Jun 26, 2019

⌛ Trying commit 5071332 with merge 218056d...
bors-servo added a commit that referenced this pull request Jun 26, 2019
@bors-servo
Auto merge of #23587 - jdm:smup67, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
218056d 
Upgrade to SpiderMonkey 67

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23587)
<!-- Reviewable:end -->
@asajeffrey
Copy link
Member

asajeffrey commented Jun 26, 2019

Can we use update-alternatives to pick an llvm version? c.f. https://kwangyulseo.com/2014/02/05/using-multiple-llvm-versions-on-ubuntu/
@jdm
Copy link
Member Author

jdm commented Jun 26, 2019

Looks like I was just missing the llvm-dev package as well.
@jdm jdm force-pushed the jdm:smup67 branch from 5071332 to 8571820 Jun 26, 2019
@asajeffrey
Copy link
Member

asajeffrey commented Jun 26, 2019

Ah, the dependencies are clang - clang-6.0 - llvm-dev-6.0, but that doesn't bring in llvm-dev.
@jdm
Upgrade to Spidermonkey 67.
Loading status checks…
63714c9
@jdm jdm force-pushed the jdm:smup67 branch from 8571820 to 63714c9 Jun 26, 2019
@jdm
Copy link
Member Author

jdm commented Jun 26, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jun 26, 2019

📌 Commit 63714c9 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned Manishearth Jun 26, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Jun 26, 2019

⌛ Testing commit 63714c9 with merge 5720531...
bors-servo added a commit that referenced this pull request Jun 26, 2019
@bors-servo
Auto merge of #23587 - jdm:smup67, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5720531 
Upgrade to SpiderMonkey 67

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23587)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing 5720531 to master...
@bors-servo bors-servo merged commit 63714c9 into servo:master Jun 27, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced Jun 27, 2019
Merged
Merged
@CYBAI CYBAI mentioned this pull request Jul 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @bors-servo @asajeffrey @Manishearth
You can’t perform that action at this time.