Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for market:// urls #23649

Merged
merged 1 commit into from Jun 29, 2019
Merged

Add support for market:// urls #23649

merged 1 commit into from Jun 29, 2019

Conversation

@jdm
Copy link
Member

jdm commented Jun 27, 2019 •
edited by SimonSapin

Rebased from #23648.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21992.
  • These changes do not require tests because can't test embedders.

This change is Reviewable
@jdm
Copy link
Member Author

jdm commented Jun 27, 2019

@bors-servo r=paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2019

📌 Commit c1a455b has been approved by paulrouget
@highfive highfive assigned paulrouget and unassigned avadacatavra Jun 27, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2019

⌛ Testing commit c1a455b with merge 5249a98...
bors-servo added a commit that referenced this pull request Jun 28, 2019
@bors-servo
Auto merge of #23649 - jdm:marketplace, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5249a98 
Add support for market:// urls

Rebased from #23648.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21992.
- [x] These changes do not require tests because can't test embedders.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23649)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Jun 28, 2019

In magicleap build:

error[E0046]: not all trait items implemented, missing: `on_allow_navigation`
   --> ports/libmlservo/src/lib.rs:338:1
    |
338 | impl HostTrait for HostCallbacks {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `on_allow_navigation` in implementation
    |
    = note: `on_allow_navigation` from trait: `fn(&Self, std::string::String) -> bool`

error: aborting due to previous error
@jdm jdm force-pushed the jdm:marketplace branch from c1a455b to feba068 Jun 28, 2019
@jdm
Copy link
Member Author

jdm commented Jun 28, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2019

📌 Commit feba068 has been approved by jdm
@highfive highfive assigned jdm and unassigned paulrouget Jun 28, 2019
@servo-wpt-sync servo-wpt-sync mentioned this pull request Jun 28, 2019
Closed
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 28, 2019

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#17575.
@jdm jdm force-pushed the jdm:marketplace branch from feba068 to 6e05790 Jun 28, 2019
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jun 28, 2019

No upstreamable changes; closed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#17575.
@jdm
Copy link
Member Author

jdm commented Jun 28, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2019

📌 Commit 6e05790 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2019

⌛ Testing commit 6e05790 with merge 4a1f320...
bors-servo added a commit that referenced this pull request Jun 28, 2019
@bors-servo
Auto merge of #23649 - jdm:marketplace, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4a1f320 
Add support for market:// urls

Rebased from #23648.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21992.
- [x] These changes do not require tests because can't test embedders.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23649)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2019

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:marketplace branch from 6e05790 to 53b4bc2 Jun 28, 2019
@jdm
Copy link
Member Author

jdm commented Jun 28, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2019

📌 Commit 53b4bc2 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2019

⌛ Testing commit 53b4bc2 with merge 98047e2...
bors-servo added a commit that referenced this pull request Jun 28, 2019
@bors-servo
Auto merge of #23649 - jdm:marketplace, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
98047e2 
Add support for market:// urls

Rebased from #23648.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21992.
- [x] These changes do not require tests because can't test embedders.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23649)
<!-- Reviewable:end -->
@akshitkrnagpal @jdm
Add support for market:// urls
Loading status checks…
027514c
@jdm jdm force-pushed the jdm:marketplace branch from 53b4bc2 to 027514c Jun 28, 2019
@jdm
Copy link
Member Author

jdm commented Jun 28, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2019

📌 Commit 027514c has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jun 28, 2019

⌛ Testing commit 027514c with merge 177b2a6...
bors-servo added a commit that referenced this pull request Jun 28, 2019
@bors-servo
Auto merge of #23649 - jdm:marketplace, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
177b2a6 
Add support for market:// urls

Rebased from #23648.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21992.
- [x] These changes do not require tests because can't test embedders.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23649)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 177b2a6 to master...
@bors-servo bors-servo merged commit 027514c into servo:master Jun 29, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Support for market:// urls
8 participants
@jdm @bors-servo @CYBAI @servo-wpt-sync @paulrouget @highfive @avadacatavra @akshitkrnagpal
You can’t perform that action at this time.