New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement checks on Location setters #23670
Closed
+27
−37
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9845249
only allow http/https protocols
braddunbar 3c8df69
host or hostname: abort if url cannot be a base
braddunbar 97e967c
port: abort if url cannot have username/password/port
braddunbar 3f2abcc
pathname: terminate if cannot-be-a-base
braddunbar 6c31813
remove failure expectations
braddunbar 05f7547
link to cannot have a username password spec
braddunbar File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
link to cannot have a username password spec
- Loading branch information
braddunbar
committed
Jul 1, 2019
braddunbar
Brad Dunbar
commit 05f75473ff252b5e774031e17341b37b28d010b7
Verified
This commit was signed with a verified signature.
GPG key ID: C32E3CC9B201C719
Learn about signing commits
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Here you could add a link to the spec: https://url.spec.whatwg.org/#cannot-have-a-username-password-port