Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a WebXR device registry to each script thread #23690

Merged
merged 1 commit into from Jul 3, 2019
Merged

Get a WebXR device registry to each script thread #23690

merged 1 commit into from Jul 3, 2019

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jul 2, 2019 •
edited by SimonSapin

This PR gets an XR device registry to each script thread.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it's all plumbing

This change is Reviewable
@highfive
Copy link

highfive commented Jul 2, 2019

Heads up! This PR modifies the following files:

  • @cbrewster: components/constellation/pipeline.rs, components/constellation/Cargo.toml, components/constellation/constellation.rs
  • @paulrouget: components/constellation/pipeline.rs, components/constellation/Cargo.toml, components/compositing/Cargo.toml, components/constellation/constellation.rs, components/compositing/windowing.rs and 3 more
  • @KiChjang: components/script/Cargo.toml, components/script/dom/bindings/trace.rs, components/script/script_thread.rs, components/script_traits/Cargo.toml, components/script_traits/lib.rs
@highfive
Copy link

highfive commented Jul 2, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 2, 2019

Depends on #23675 and servo/webxr#3
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 2, 2019

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned jdm Jul 2, 2019
@Manishearth
Manishearth approved these changes Jul 2, 2019
View changes
Cargo.toml Outdated Show resolved Hide resolved
@bors-servo
Copy link
Contributor

bors-servo commented Jul 2, 2019

☔ The latest upstream changes (presumably #23641) made this pull request unmergeable. Please resolve the merge conflicts.
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-script-thread branch from 6fdb7da to bfa8733 Jul 2, 2019
@asajeffrey
Use webxr IPC to get a WebXR device registry to each script thread
Loading status checks…
9eb75d4
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-script-thread branch from bfa8733 to 9eb75d4 Jul 3, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 3, 2019

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

📌 Commit 9eb75d4 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

⌛ Testing commit 9eb75d4 with merge 661170c...
bors-servo added a commit that referenced this pull request Jul 3, 2019
@bors-servo
Auto merge of #23690 - asajeffrey:webxr-script-thread, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
661170c 
Get a WebXR device registry to each script thread

<!-- Please describe your changes on the following line: -->

This PR gets an XR device registry to each script thread.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's all plumbing

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23690)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing 661170c to master...
@bors-servo bors-servo merged commit 9eb75d4 into servo:master Jul 3, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
This was referenced Jul 3, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
A-webvr A-xr-zomg
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@asajeffrey @highfive @bors-servo @Manishearth @jdm
You can’t perform that action at this time.