Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UWP port - bis #23696

Merged
merged 8 commits into from Jul 4, 2019
Merged

Add UWP port - bis #23696

merged 8 commits into from Jul 4, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Jul 3, 2019 •
edited by SimonSapin

This is #23658 with some fixes:

  • removed nspr from DLL dependencies (was breaking VS build)
  • exclude symbols from header file (was breaking VS build)
  • rebased

Before merging:

  • please check the rebased commit that introduces the --uwp option (things moved around since 7c85dc0)
  • should we wait until the WR fix lands upstream?

This change is Reviewable
@highfive
Copy link

highfive commented Jul 3, 2019

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/command_base.py, python/servo/build_commands.py
@highfive
Copy link

highfive commented Jul 3, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 3, 2019

@jdm r?
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 3, 2019

tidy is really unhappy. Gonna fix that.
@jdm
jdm approved these changes Jul 3, 2019
View changes
@jdm
Copy link
Member

jdm commented Jul 3, 2019

One issue I keep seeing - building twice in a row with --uwp causes a lot (but not all) of servo's dependencies to be rebuilt, even though no changes occurred. I'm trying to figure out what's causing that.
@jdm
Copy link
Member

jdm commented Jul 3, 2019

I can no longer reproduce the build issue from the previous comment.
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 3, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

📌 Commit c97a62a has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Jul 3, 2019
This was referenced Jul 3, 2019
Closed
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

☔ The latest upstream changes (presumably #23690) made this pull request unmergeable. Please resolve the merge conflicts.
paulrouget and others added 8 commits May 29, 2019
@paulrouget
implement Visual Studio logs
0d96bbd
@paulrouget
Use StaticStructGenerator on Windows
3650f35
@jdm @paulrouget
Use fixed webrender.
5beac07
@paulrouget
Hololens port
acde7e0
@paulrouget
Hololens documentation
bc85472
@jdm @paulrouget
Fix EGL linking.
f2e0870
@jdm @paulrouget
Simplify build process for UWP app.
7a3d346
@paulrouget
Do not include useless symbols to simpleservo.h
Loading status checks…
71abf13
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 3, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

📌 Commit 71abf13 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2019

⌛ Testing commit 71abf13 with merge b32bff3...
bors-servo added a commit that referenced this pull request Jul 4, 2019
@bors-servo
Auto merge of #23696 - servo:hl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b32bff3 
Add UWP port - bis

This is #23658 with some fixes:
- removed nspr from DLL dependencies (was breaking VS build)
- exclude symbols from header file (was breaking VS build)
- rebased

Before merging:
- please check the rebased commit that introduces the `--uwp` option (things moved around since 7c85dc0)
- should we wait until the WR fix lands upstream?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23696)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing b32bff3 to master...
@bors-servo bors-servo merged commit 71abf13 into master Jul 4, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced Jul 4, 2019
Merged
Closed
@SimonSapin SimonSapin deleted the hl branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@paulrouget @highfive @jdm @bors-servo @asajeffrey
You can’t perform that action at this time.