Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suppress build errors. #23701

Merged
merged 1 commit into from Jul 3, 2019
Merged

Don't suppress build errors. #23701

merged 1 commit into from Jul 3, 2019

Conversation

@jdm
Copy link
Member

jdm commented Jul 3, 2019 •
edited by SimonSapin

This is a regression from #23676.

This change is Reviewable
@jdm
Don't suppress build errors.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fc8c428
@highfive
Copy link

highfive commented Jul 3, 2019

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Jul 3, 2019

@bors-servo p=100
@asajeffrey
Copy link
Member

asajeffrey commented Jul 3, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

📌 Commit fc8c428 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned paulrouget Jul 3, 2019
@Manishearth
Copy link
Member

Manishearth commented Jul 3, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #23564
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

📌 Commit fc8c428 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned asajeffrey Jul 3, 2019
@SimonSapin
Copy link
Member

SimonSapin commented Jul 3, 2019

Oops :] This was left over from working around an android linker failure. Sorry I forgot to remove it before landing!
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

⌛ Testing commit fc8c428 with merge c9d7b4e...
bors-servo added a commit that referenced this pull request Jul 3, 2019
@bors-servo
Auto merge of #23701 - servo:jdm-patch-30, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c9d7b4e 
Don't suppress build errors.

This is a regression from #23676.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23701)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing c9d7b4e to master...
@bors-servo bors-servo merged commit fc8c428 into master Jul 3, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-30 branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@jdm @highfive @asajeffrey @bors-servo @Manishearth @SimonSapin @paulrouget
You can’t perform that action at this time.