Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media update global mute #23714

Merged
merged 2 commits into from Jul 5, 2019
Merged

Media update global mute #23714

merged 2 commits into from Jul 5, 2019

Conversation

@ferjm
Copy link
Member

ferjm commented Jul 5, 2019 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable
ferjm added 2 commits Jul 5, 2019
@ferjm
Update servo media to include global mute support
8e0160f
@ferjm
AudioContext shutdown
Loading status checks…
7ff4736
@highfive
Copy link

highfive commented Jul 5, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/audionode.rs, components/script/dom/audiocontext.rs, components/script/dom/audioparam.rs, components/script/dom/offlineaudiocontext.rs, components/script/dom/htmlmediaelement.rs and 2 more
  • @KiChjang: components/script/dom/audionode.rs, components/script/dom/audiocontext.rs, components/script/dom/audioparam.rs, components/script/dom/offlineaudiocontext.rs, components/script/dom/htmlmediaelement.rs and 2 more
@highfive
Copy link

highfive commented Jul 5, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@ferjm
Copy link
Member Author

ferjm commented Jul 5, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2019

⌛ Trying commit 7ff4736 with merge 85e0f67...
bors-servo added a commit that referenced this pull request Jul 5, 2019
@bors-servo
Auto merge of #23714 - ferjm:media-update-global-mute, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
85e0f67 
Media update global mute

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23714)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@ferjm
Copy link
Member Author

ferjm commented Jul 5, 2019

r? @jdm
@highfive highfive assigned jdm and unassigned emilio Jul 5, 2019
@jdm
Copy link
Member

jdm commented Jul 5, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2019

📌 Commit 7ff4736 has been approved by jdm
@jdm
Copy link
Member

jdm commented Jul 5, 2019

@bors-servo retry
@jdm
Copy link
Member

jdm commented Jul 5, 2019

@bors-servo r-
@jdm
Copy link
Member

jdm commented Jul 5, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2019

📌 Commit 7ff4736 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2019

⌛ Testing commit 7ff4736 with merge 683bd0d...
bors-servo added a commit that referenced this pull request Jul 5, 2019
@bors-servo
Auto merge of #23714 - ferjm:media-update-global-mute, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
683bd0d 
Media update global mute

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23714)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 683bd0d to master...
@bors-servo bors-servo merged commit 7ff4736 into servo:master Jul 5, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@ferjm @highfive @bors-servo @jdm @emilio
You can’t perform that action at this time.