Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build option to ignore packaging errors. #23752

Closed
wants to merge 2 commits into from
Closed

Add build option to ignore packaging errors. #23752

wants to merge 2 commits into from

Conversation

@jdm
Copy link
Member

jdm commented Jul 11, 2019 •
edited by SimonSapin

Works around #23749.

This change is Reviewable
@highfive
Copy link

highfive commented Jul 11, 2019

Heads up! This PR modifies the following files:
@saschanaz
Copy link
Contributor

saschanaz commented Jul 12, 2019

Does this assume that the new dll requirement in #23749 is actually not needed?
@jdm
Copy link
Member Author

jdm commented Jul 12, 2019

It is only a workaround for appveyor in particular.
jdm added 2 commits Jul 11, 2019
@jdm
Add build option to ignore packaging errors.
ad615fa
@jdm
Ignore gstreamer packaging errors on Appveyor.
Loading status checks…
522b4af
@jdm jdm force-pushed the jdm-patch-38 branch from d3bbd86 to 522b4af Jul 12, 2019
@jdm
Copy link
Member Author

jdm commented Jul 12, 2019

r? @SimonSapin
@highfive highfive assigned SimonSapin and unassigned asajeffrey Jul 12, 2019
@SimonSapin
Copy link
Member

SimonSapin commented Jul 12, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2019

📌 Commit 522b4af has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2019

⌛ Testing commit 522b4af with merge a7b4af8...
bors-servo added a commit that referenced this pull request Jul 12, 2019
@bors-servo
Auto merge of #23752 - servo:jdm-patch-38, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a7b4af8 
Add build option to ignore packaging errors.

Works around #23749.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23752)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented Jul 12, 2019

@bors-servo r-
#23765 is a better solution.
@jdm jdm closed this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @highfive @saschanaz @SimonSapin @bors-servo @asajeffrey
You can’t perform that action at this time.