Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix script crash on handling new layout #23761

Closed
wants to merge 4 commits into from
Closed

[WIP] Fix script crash on handling new layout #23761

wants to merge 4 commits into from
+111 −4

Conversation

@gterzian
Copy link
Member

gterzian commented Jul 12, 2019 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #23760 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable
@gterzian gterzian changed the title [WIP] Fxi script crash on handling new layout [WIP] Fix script crash on handling new layout Jul 12, 2019
@gterzian gterzian mentioned this pull request Jul 12, 2019
Open
@gterzian gterzian force-pushed the gterzian:fix_script_crash_on_new_layout branch from 793e2c6 to 24f7009 Jul 12, 2019
gterzian added 3 commits Jul 12, 2019
@gterzian
add test that crashes script on handling new layout
54d7c7a
@gterzian
try to remove empty event-loop
d148a68
@gterzian
check
Loading status checks…
2e4bfa1
@gterzian gterzian force-pushed the gterzian:fix_script_crash_on_new_layout branch from 24f7009 to 2e4bfa1 Aug 1, 2019
@gterzian gterzian mentioned this pull request Aug 1, 2019
Open
@gterzian
lower session history max length
Loading status checks…
582e049
@bors-servo
Copy link
Contributor

bors-servo commented Oct 19, 2019

☔ The latest upstream changes (presumably #23637) made this pull request unmergeable. Please resolve the merge conflicts.
@gterzian gterzian closed this Jan 7, 2020
@gterzian gterzian deleted the gterzian:fix_script_crash_on_new_layout branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@avadacatavra avadacatavra

Labels
S-awaiting-review S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Script crash on handling new layout - cross-origin iframe
4 participants
@gterzian @bors-servo @highfive @avadacatavra
You can’t perform that action at this time.