Adjust gstreamer plugins for UWP. #23764

jdm · 2019-07-12T13:05:37Z

This excludes a set of plugins and dependencies that are currently built with MinGW and will therefore cause WACK errors. The resulting set of plugins loaded by the UWP app are still not UWP-clean, but this makes it much easier to switch over to UWP-clean binaries in the future.

These changes also allow the HoloLens 2 app to start and load again after #23712.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #23757
These changes do not require tests because no tests for windows or UWP.

This change is

highfive · 2019-07-12T13:05:41Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/build_commands.py

jdm · 2019-07-12T13:05:47Z

r? @paulrouget

paulrouget · 2019-07-12T14:33:01Z

Looks good to me.


        Adjust gstreamer plugins for UWP.

jdm · 2019-07-12T14:35:41Z

@bors-servo r=paulrouget

bors-servo · 2019-07-12T14:35:41Z

📌 Commit ce01cd7 has been approved by paulrouget

bors-servo · 2019-07-13T01:44:04Z

⌛ Testing commit ce01cd7 with merge 0545319...


        Auto merge of #23764 - jdm:hl-startup, r=paulrouget

Adjust gstreamer plugins for UWP. This excludes a set of plugins and dependencies that are currently built with MinGW and will therefore cause WACK errors. The resulting set of plugins loaded by the UWP app are still not UWP-clean, but this makes it much easier to switch over to UWP-clean binaries in the future. These changes also allow the HoloLens 2 app to start and load again after #23712. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23757 - [x] These changes do not require tests because no tests for windows or UWP.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23764)

bors-servo · 2019-07-13T02:11:07Z

💔 Test failed - linux-rel-css

jdm · 2019-07-13T04:59:59Z

@bors-servo retry

#17230

bors-servo · 2019-07-13T06:42:31Z

⌛ Testing commit ce01cd7 with merge 7075979...


        Auto merge of #23764 - jdm:hl-startup, r=paulrouget

Adjust gstreamer plugins for UWP. This excludes a set of plugins and dependencies that are currently built with MinGW and will therefore cause WACK errors. The resulting set of plugins loaded by the UWP app are still not UWP-clean, but this makes it much easier to switch over to UWP-clean binaries in the future. These changes also allow the HoloLens 2 app to start and load again after #23712. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23757 - [x] These changes do not require tests because no tests for windows or UWP.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23764)

bors-servo · 2019-07-13T09:17:28Z

💔 Test failed - status-taskcluster

CYBAI · 2019-07-13T11:38:19Z

@bors-servo retry

#23290

bors-servo · 2019-07-13T11:38:21Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2019-07-13T11:38:25Z

⌛ Testing commit ce01cd7 with merge 6c49bd1...


        Auto merge of #23764 - jdm:hl-startup, r=paulrouget

Adjust gstreamer plugins for UWP. This excludes a set of plugins and dependencies that are currently built with MinGW and will therefore cause WACK errors. The resulting set of plugins loaded by the UWP app are still not UWP-clean, but this makes it much easier to switch over to UWP-clean binaries in the future. These changes also allow the HoloLens 2 app to start and load again after #23712. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23757 - [x] These changes do not require tests because no tests for windows or UWP.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23764)

bors-servo · 2019-07-13T12:32:36Z

💔 Test failed - status-taskcluster

jdm · 2019-07-13T13:13:05Z

@bors-servo retry
#23290

bors-servo · 2019-07-13T13:13:07Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2019-07-13T13:13:11Z

⌛ Testing commit ce01cd7 with merge f597e22...


        Auto merge of #23764 - jdm:hl-startup, r=paulrouget

Adjust gstreamer plugins for UWP. This excludes a set of plugins and dependencies that are currently built with MinGW and will therefore cause WACK errors. The resulting set of plugins loaded by the UWP app are still not UWP-clean, but this makes it much easier to switch over to UWP-clean binaries in the future. These changes also allow the HoloLens 2 app to start and load again after #23712. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23757 - [x] These changes do not require tests because no tests for windows or UWP.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23764)

bors-servo · 2019-07-13T13:57:15Z

💔 Test failed - status-taskcluster

jdm · 2019-07-13T14:15:23Z

@bors-servo retry

bors-servo · 2019-07-13T14:15:25Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2019-07-13T14:15:29Z

⌛ Testing commit ce01cd7 with merge 1fb81f0...


        Auto merge of #23764 - jdm:hl-startup, r=paulrouget

Adjust gstreamer plugins for UWP. This excludes a set of plugins and dependencies that are currently built with MinGW and will therefore cause WACK errors. The resulting set of plugins loaded by the UWP app are still not UWP-clean, but this makes it much easier to switch over to UWP-clean binaries in the future. These changes also allow the HoloLens 2 app to start and load again after #23712. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23757 - [x] These changes do not require tests because no tests for windows or UWP.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23764)

bors-servo · 2019-07-13T15:11:46Z

💔 Test failed - status-taskcluster

jdm · 2019-07-13T15:31:21Z

@bors-servo retry

#23290

bors-servo · 2019-07-13T15:31:23Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2019-07-13T15:31:28Z

⌛ Testing commit ce01cd7 with merge 8328763...


        Auto merge of #23764 - jdm:hl-startup, r=paulrouget

Adjust gstreamer plugins for UWP. This excludes a set of plugins and dependencies that are currently built with MinGW and will therefore cause WACK errors. The resulting set of plugins loaded by the UWP app are still not UWP-clean, but this makes it much easier to switch over to UWP-clean binaries in the future. These changes also allow the HoloLens 2 app to start and load again after #23712. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23757 - [x] These changes do not require tests because no tests for windows or UWP.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23764)

bors-servo · 2019-07-13T16:27:17Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: paulrouget
Pushing 8328763 to master...

highfive assigned nox Jul 12, 2019

highfive added the S-awaiting-review label Jul 12, 2019

highfive assigned paulrouget and unassigned nox Jul 12, 2019

Adjust gstreamer plugins for UWP.

Loading status checks…

ce01cd7

jdm force-pushed the jdm:hl-startup branch from 4dcee36 to ce01cd7 Jul 12, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 12, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 13, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Jul 13, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 13, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Jul 13, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 13, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Jul 13, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 13, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Jul 13, 2019

bors-servo merged commit ce01cd7 into servo:master Jul 13, 2019
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details

Taskcluster (pull_request) TaskGroup: success
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jul 13, 2019

servo / servo

Adjust gstreamer plugins for UWP. #23764

Adjust gstreamer plugins for UWP. #23764

jdm commented Jul 12, 2019 •

edited by SimonSapin

highfive commented Jul 12, 2019

jdm commented Jul 12, 2019

paulrouget commented Jul 12, 2019

jdm commented Jul 12, 2019

bors-servo commented Jul 12, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

jdm commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

CYBAI commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

jdm commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

jdm commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

jdm commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

servo / servo

Join GitHub today

Adjust gstreamer plugins for UWP. #23764

Adjust gstreamer plugins for UWP. #23764

Conversation

jdm commented Jul 12, 2019 • edited by SimonSapin

highfive commented Jul 12, 2019

jdm commented Jul 12, 2019

paulrouget commented Jul 12, 2019

jdm commented Jul 12, 2019

bors-servo commented Jul 12, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

jdm commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

CYBAI commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

jdm commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

jdm commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

jdm commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

bors-servo commented Jul 13, 2019

jdm commented Jul 12, 2019 •

edited by SimonSapin