Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor: Fix missing gstreamer dlls #23765

Merged
merged 1 commit into from Jul 13, 2019
Merged

Appveyor: Fix missing gstreamer dlls #23765

merged 1 commit into from Jul 13, 2019

Conversation

@UK992
Copy link
Contributor

UK992 commented Jul 12, 2019 •
edited by SimonSapin

This changes will execute complete installation of gstreamer. And should fix #23749

This change is Reviewable
@UK992
Fix Appveyor
Loading status checks…
5260930
@highfive
Copy link

highfive commented Jul 12, 2019

Heads up! This PR modifies the following files:
@jdm
Copy link
Member

jdm commented Jul 12, 2019

Aha, thanks for finding that option!
@jdm jdm mentioned this pull request Jul 12, 2019
Closed
@jdm
Copy link
Member

jdm commented Jul 12, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2019

📌 Commit 5260930 has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Jul 12, 2019
@jdm
Copy link
Member

jdm commented Jul 12, 2019

@UK992 Out of curiosity, how did you figure that out?
@saschanaz
Copy link
Contributor

saschanaz commented Jul 12, 2019 •
edited

Could we enable only the required one rather than =ALL? Might be better to detect when requirement changes.

PS: Okay, the right name is _gstreamer_1.0_libav_devel but it really requires enumerating everything installed: ADDLOCAL = _gstreamer_1.0_core_devel,_gstreamer_1.0_devel,_gstreamer_1.0_system_devel,_gstreamer_1.0_playback_devel,_gstreamer_1.0_codecs_devel,_gstreamer_1.0_effects_devel,_gstreamer_1.0_net_devel,_gstreamer_1.0_visualizers_devel,_gstreamer_1.0_libav_devel,_vsintegration_1.0_devel
@UK992
Copy link
Contributor Author

UK992 commented Jul 12, 2019

@jdm many search queries related to gstreamer msi installer arguments / properties and somehow found out someone using ADDLOCAL on gstreamer installer. Then testing, installing and removing gstreamer many times. :)
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2019

⌛ Testing commit 5260930 with merge 30ca50a...
bors-servo added a commit that referenced this pull request Jul 13, 2019
@bors-servo
Auto merge of #23765 - UK992:appveyor, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
30ca50a 
Appveyor: Fix missing gstreamer dlls

This changes will execute complete installation of gstreamer. And should fix #23749

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23765)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 30ca50a to master...
@bors-servo bors-servo merged commit 5260930 into servo:master Jul 13, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Appveyor is broken after gstreamer packaging changes
6 participants
@UK992 @highfive @jdm @bors-servo @saschanaz @nox
You can’t perform that action at this time.