Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnbreak angle #23768
Merged
Unbreak angle #23768
+11
−9
Conversation
highfive
commented
Jul 12, 2019
|
Heads up! This PR modifies the following files:
|
|
@bors-servo try=windows |
bors-servo
added a commit
that referenced
this pull request
Jul 12, 2019
Unbreak angle This updates our ANGLE integration to a working version that allows nightly builds to run with `--angle` once more. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23656 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23768) <!-- Reviewable:end -->
|
The new automated test to verify that ANGLE works passed: https://treeherder.allizom.org/#/jobs?repo=servo-try&revision=33e3fbb97cdba9c8149fe962983d076277d3e17c Oh frabjous day! Calloo callay! This PR is ready for review. |
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 13, 2019
Unbreak angle This updates our ANGLE integration to a working version that allows nightly builds to run with `--angle` once more. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23656 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23768) <!-- Reviewable:end -->
|
|
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 13, 2019
Unbreak angle This updates our ANGLE integration to a working version that allows nightly builds to run with `--angle` once more. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23656 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23768) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJul 12, 2019
•
edited by SimonSapin
This updates our ANGLE integration to a working version that allows nightly builds to run with
--angleonce more../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is