Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidpi parameter of android #2377

Merged
merged 1 commit into from May 9, 2014
Merged

Fix hidpi parameter of android #2377

merged 1 commit into from May 9, 2014

Conversation

@aydinkim
Copy link

aydinkim commented May 9, 2014

Fix for android rendering.
Need to consider about getting accurate size framebuffer & window parameter respectively from android stack and follow up the stuffs on another platform.
aydin.kim
fix hidpi parameter of android
Loading status checks…
6d18ca4
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 9, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1514

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@aydinkim aydinkim mentioned this pull request May 9, 2014
Closed
@larsbergstrom

This comment has been minimized.

Sign in to view
Copy link

larsbergstrom commented on 6d18ca4 May 9, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 6d18ca4 May 9, 2014

saw approval from larsbergstrom
at aydinkim@6d18ca4

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 9, 2014

merging aydinkim/servo/hidpi = 6d18ca4 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 9, 2014

aydinkim/servo/hidpi = 6d18ca4 merged ok, testing candidate = 052d3cb

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 9, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/1387
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1341

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 9, 2014

fast-forwarding master to auto = 052d3cb
bors-servo pushed a commit that referenced this pull request May 9, 2014
bors-servo
auto merge of #2377 : aydinkim/servo/hidpi, r=larsbergstrom
052d3cb 
Fix for android rendering.
Need to consider about getting accurate size framebuffer & window parameter respectively from android stack and follow up the stuffs on another platform.
@bors-servo bors-servo merged commit 6d18ca4 into servo:master May 9, 2014
1 check passed
1 check passed
default all tests passed
@mbrubeck mbrubeck mentioned this pull request Jul 24, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@aydinkim @hoppipolla-critic-bot @bors-servo @larsbergstrom
You can’t perform that action at this time.