Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed performance interface's timing to an attribute #23773

Closed
wants to merge 1 commit into from

Conversation

@bcamp
Copy link

bcamp commented Jul 15, 2019


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #23330 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable

@highfive
Copy link

highfive commented Jul 15, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

@highfive
Copy link

highfive commented Jul 15, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/Performance.webidl
  • @KiChjang: components/script/dom/webidls/Performance.webidl
@highfive
Copy link

highfive commented Jul 15, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jul 15, 2019

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2019

Trying commit 58557e0 with merge 7a64745...

bors-servo added a commit that referenced this pull request Jul 15, 2019
Changed performance interface's timing to an attribute

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23330 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23773)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2019

💔 Test failed - linux-rel-css

@jdm
Copy link
Member

jdm commented Jul 15, 2019

./mach test-wpt tests/wpt/mozilla/window_performance.html is now panicking when calling Performance::Timing.

@jdm
Copy link
Member

jdm commented Jul 15, 2019

More specifically, the panic occurs because in this code there is no navigation timing entry that has been reported when a page like this is loaded:

<script>
console.log(navigation.timing)
</script>

This occurs because we only register performance entries when a response is complete, rather than when the first bytes are received. I think we need to update all of the resource timing code to submit twice - when the first bytes are received, and then update the existing entry when all of the final timings are available.

We could:

@bcamp
Copy link
Author

bcamp commented Jul 17, 2019

Just updating to say that I'm working on an implementation of your proposed solution. Should have an update some time this week.

@jdm
Copy link
Member

jdm commented Sep 3, 2019

@bcamp Are you still working on this? :)

@bcamp
Copy link
Author

bcamp commented Sep 4, 2019

My bad, this completely slipped my mind as work and school have been consuming my time. I don't think I'll be able to get to this in a timely manner (as already displayed).

@bcamp bcamp closed this Sep 4, 2019
@bcamp bcamp deleted the bcamp:timing_to_attr branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.