Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChanged performance interface's timing to an attribute #23773
Conversation
highfive
commented
Jul 15, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
highfive
commented
Jul 15, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 15, 2019
|
@bors-servo try=wpt |
Changed performance interface's timing to an attribute <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23330 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23773) <!-- Reviewable:end -->
|
|
|
|
|
More specifically, the panic occurs because in this code there is no navigation timing entry that has been reported when a page like this is loaded: <script>
console.log(navigation.timing)
</script>This occurs because we only register performance entries when a response is complete, rather than when the first bytes are received. I think we need to update all of the resource timing code to submit twice - when the first bytes are received, and then update the existing entry when all of the final timings are available. We could:
|
|
Just updating to say that I'm working on an implementation of your proposed solution. Should have an update some time this week. |
|
@bcamp Are you still working on this? :) |
|
My bad, this completely slipped my mind as work and school have been consuming my time. I don't think I'll be able to get to this in a timely manner (as already displayed). |
bcamp commentedJul 15, 2019
•
edited by SimonSapin
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is