Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInitial Actions support in WebDriver #23805
Merged
Conversation
highfive
commented
Jul 18, 2019
|
Heads up! This PR modifies the following files:
|
|
Good start! |
|
I tested this manually for now and it seems to be working fine. |
|
Looking good! |
| use webdriver::actions::{PointerAction, PointerActionItem, PointerType}; | ||
|
|
||
| // https://w3c.github.io/webdriver/#dfn-input-source-state | ||
| pub enum InputSourceState { |
This comment has been minimized.
This comment has been minimized.
|
|
||
| impl WebDriverSession { | ||
| // https://w3c.github.io/webdriver/#dfn-dispatch-actions | ||
| pub fn dispatch_actions( |
This comment has been minimized.
This comment has been minimized.
| // https://w3c.github.io/webdriver/#dfn-dispatch-actions | ||
| pub fn dispatch_actions( | ||
| &mut self, | ||
| constellation_chan: Sender<ConstellationMsg>, |
This comment has been minimized.
This comment has been minimized.
| PointerAction::Cancel => (), | ||
| PointerAction::Down(action) => (), | ||
| PointerAction::Move(action) => (), | ||
| PointerAction::Up(action) => (), |
This comment has been minimized.
This comment has been minimized.
| }); | ||
|
|
||
| match key_input_state.dispatch_keyup(raw_key) { | ||
| Some(keyboard_event) => { |
This comment has been minimized.
This comment has been minimized.
|
@jdm Any other changes for this one? |
|
Otherwise this looks fine. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 6, 2019
…er, r=jdm Initial Actions support in WebDriver <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23805) <!-- Reviewable:end -->
|
|
|
Oh, it looks like the test I added in https://hg.mozilla.org/mozilla-central/rev/fff7b5299ecf triggers a panick in the server. This should get solved once |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 15, 2019
…er, r=jdm Initial Actions support in WebDriver <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23805) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Aug 15, 2019
…er, r=jdm Initial Actions support in WebDriver <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23805) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
georgeroman commentedJul 18, 2019
•
edited by SimonSapin
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is