Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove debug functions to Window IDL. #2381
Conversation
This is a cleaner way to expose those functions, and makes it possible to remove a significant amount code in rust-mozjs. The assert() function is no longer exposed, as it was unused and not very useful.
hoppipolla-critic-bot
commented
May 9, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1518 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
May 9, 2014
|
|
|
Depends on servo/rust-mozjs#79 |
This comment has been minimized.
This comment has been minimized.
jdm
commented on 30055d9
May 9, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging Ms2ger/servo/mozjs-spring-cleanup = 30055d9 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 78917f4 |
This is a cleaner way to expose those functions, and makes it possible to remove a significant amount code in rust-mozjs. The assert() function is no longer exposed, as it was unused and not very useful.
bors-servo
merged commit 30055d9
into
servo:master
Ms2ger commentedMay 9, 2014
This is a cleaner way to expose those functions, and makes it possible to
remove a significant amount code in rust-mozjs.
The assert() function is no longer exposed, as it was unused and not very
useful.