Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Sync changes from mozilla-central, and update euclid #23827

Merged
merged 23 commits into from Jul 24, 2019
Merged

style: Sync changes from mozilla-central, and update euclid #23827

merged 23 commits into from Jul 24, 2019

Conversation

@emilio
Copy link
Member

emilio commented Jul 22, 2019 •
edited by SimonSapin

See individual commits for details.

This change is Reviewable
@highfive
Copy link

highfive commented Jul 22, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlcanvaselement.rs, components/constellation/browsingcontext.rs, components/script/dom/imagedata.rs, components/script/Cargo.toml, components/script/dom/offscreencanvasrenderingcontext2d.rs and 35 more
  • @cbrewster: components/constellation/browsingcontext.rs, components/constellation/constellation.rs, components/constellation/pipeline.rs, components/constellation/Cargo.toml
  • @jgraham: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
  • @KiChjang: components/script/dom/htmlcanvaselement.rs, components/script_traits/lib.rs, components/script/dom/imagedata.rs, components/script_traits/script_msg.rs, components/script/Cargo.toml and 33 more
@highfive
Copy link

highfive commented Jul 22, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@emilio
Copy link
Member Author

emilio commented Jul 22, 2019

@bors-servo r=emilio,manishearth

(Manish took a look at the euclid update)
@bors-servo
Copy link
Contributor

bors-servo commented Jul 22, 2019

📌 Commit 7b90373 has been approved by emilio,manishearth
@highfive highfive assigned emilio and unassigned Manishearth Jul 22, 2019
@emilio emilio force-pushed the emilio:gecko-sync branch from 7b90373 to 710264e Jul 22, 2019
@emilio
Copy link
Member Author

emilio commented Jul 22, 2019

@bors-servo r=emilio,manishearth

  • Small cargo.lock update for azure which was missing when removing [patch] entries.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 22, 2019

📌 Commit 710264e has been approved by emilio,manishearth
@emilio emilio force-pushed the emilio:gecko-sync branch from 710264e to bcbb812 Jul 23, 2019
@emilio
Copy link
Member Author

emilio commented Jul 23, 2019

@bors-servo r=emilio,manishearth

  • Removed some now-dead code in unit tests.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2019

📌 Commit bcbb812 has been approved by emilio,manishearth
@emilio emilio force-pushed the emilio:gecko-sync branch from bcbb812 to 3175626 Jul 23, 2019
@emilio
Copy link
Member Author

emilio commented Jul 23, 2019

@bors-servo r=emilio,manishearth

  • Rebase due to conflicts with #23568 in servo-tidy.toml
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2019

📌 Commit 3175626 has been approved by emilio,manishearth
Thomas Nguyen and others added 12 commits Jul 16, 2019
Thomas Nguyen @emilio
style: Modify URLExtraData rust debug to include referrerInfo.
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
59cf10d 
Differential Revision: https://phabricator.services.mozilla.com/D36475
@emilio
style: Update animations when a pseudo-element had animations but no …
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
137044a 
…longer has, and has been re-framed in the meantime.

This is the easy fix.

The hard fix (outlined in the comment) would be nice, but I don't think this bug
alone justifies it.

Differential Revision: https://phabricator.services.mozilla.com/D38184
@emilio
style: Remove the ability to build Gecko without the bindgen feature.
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
66eae2f 
This is not used for anything, as far as I can tell.

Differential Revision: https://phabricator.services.mozilla.com/D38584
@nical @emilio
style: Update to euclid 0.20.
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
239f2da 
Differential Revision: https://phabricator.services.mozilla.com/D38530
Charlie Marlow @emilio
style: renamed text-decoration-width to text-decoration-thickness.
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
6bc1b97 
Differential Revision: https://phabricator.services.mozilla.com/D38586
@longsonr @emilio
style: Change dominant-baseline from reset to inherit.
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
243520f 
Bug: 1353164
Reviewed-by: heycam
@emilio
Fix Servo build.
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
8665d9d
@emilio
style: Fix a warning in Servo builds by moving a macro to where it's …
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
3da8f85 
…used.
@emilio
style: Remove unit tests that test non-compliant stuff.
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
58d51b1 
<position> no longer parses three values.
@emilio
style: Appease tidy.
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
2ff7cb5
@emilio
Update euclid.
3d57c22 
There are a few canvas2d-related dependencies that haven't updated, but they
only use euclid internally so that's not blocking landing the rest of the
changes.

Given the size of this patch, I think it's useful to get this landed as-is.
@emilio
Update WPT expectations.
Loading status checks…
9dc906a
@emilio emilio force-pushed the emilio:gecko-sync branch from 6597e92 to 9dc906a Jul 23, 2019
@emilio
Copy link
Member Author

emilio commented Jul 23, 2019

@bors-servo r=emilio,manishearth p=1

  • Rebase
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2019

📌 Commit 9dc906a has been approved by emilio,manishearth
@emilio
Copy link
Member Author

emilio commented Jul 23, 2019

(Hopefully the shameless p=1 here is ok :))
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2019

⌛ Testing commit 9dc906a with merge 8f7440f...
bors-servo added a commit that referenced this pull request Jul 23, 2019
@bors-servo
Auto merge of #23827 - emilio:gecko-sync, r=emilio,manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8f7440f 
style: Sync changes from mozilla-central, and update euclid

See individual commits for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23827)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: emilio,manishearth
Pushing 8f7440f to master...
@bors-servo bors-servo merged commit 9dc906a into servo:master Jul 24, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced Jul 24, 2019
Merged
Closed
Merged
Closed
@emilio emilio deleted the emilio:gecko-sync branch Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.