Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport Scroll in HoloLens mode #23831
Merged
Conversation
|
r? @angelortiz1007 or @jdm |
|
This doesn't work in non-HoloLens env. I could use This approach is the "Right way" for hololens. fix #23678 |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 24, 2019
Support Scroll in HoloLens mode <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23831) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 24, 2019
Support Scroll in HoloLens mode <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23831) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 24, 2019
Support Scroll in HoloLens mode <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23831) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 25, 2019
[hololens] More events, remove most of the statics, better shutdown Depends on #23831 - Buttons are greyed out when necessary - Reload, Stop, Back and Fwd are properly bound - Servo.cpp rewritten in a much cleaner way - Removed most of the statics - Improved (but not full) shutdown <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23845) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedJul 23, 2019
•
edited by SimonSapin
This change is