Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve session test lifecycle code #23839

Merged
merged 1 commit into from Jul 30, 2019
Merged

Improve session test lifecycle code #23839

merged 1 commit into from Jul 30, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jul 23, 2019 •
edited by SimonSapin

Requires servo/webxr#25

Fixes #23796, hopefully

r? @asajeffrey

This change is Reviewable
@highfive
Copy link

highfive commented Jul 23, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/xrtest.rs, components/script/dom/webidls/FakeXRDevice.webidl, components/script/dom/fakexrdevice.rs
  • @KiChjang: components/script/dom/xrtest.rs, components/script/dom/webidls/FakeXRDevice.webidl, components/script/dom/fakexrdevice.rs
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2019

☔ The latest upstream changes (presumably #23827) made this pull request unmergeable. Please resolve the merge conflicts.
@Manishearth Manishearth force-pushed the Manishearth:end-improve branch 2 times, most recently from 7d0ec7e to 32d6ea6 Jul 26, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Jul 26, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jul 26, 2019

📌 Commit 32d6ea6 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jul 26, 2019

⌛ Testing commit 32d6ea6 with merge efbf407...
bors-servo added a commit that referenced this pull request Jul 26, 2019
@bors-servo
Auto merge of #23839 - Manishearth:end-improve, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
efbf407 
Improve session test lifecycle code

Requires servo/webxr#25

Fixes #23796, hopefully

r? @asajeffrey

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23839)
<!-- Reviewable:end -->
@Manishearth Manishearth force-pushed the Manishearth:end-improve branch from 32d6ea6 to a7d78c7 Jul 26, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Jul 26, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jul 26, 2019

📌 Commit a7d78c7 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jul 26, 2019

🔒 Merge conflict
@Manishearth Manishearth force-pushed the Manishearth:end-improve branch from a7d78c7 to 437d258 Jul 27, 2019
@Manishearth Manishearth force-pushed the Manishearth:end-improve branch from 437d258 to 7915692 Jul 27, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2019

☔ The latest upstream changes (presumably #23848) made this pull request unmergeable. Please resolve the merge conflicts.
@Manishearth
Improve session test lifecycle code
Loading status checks…
d996d3c
@Manishearth Manishearth force-pushed the Manishearth:end-improve branch from 7915692 to d996d3c Jul 29, 2019
@asajeffrey
Copy link
Member

asajeffrey commented Jul 29, 2019

Apparently I only r'd this on IRC, not on github. It's still r=me!
@Manishearth
Copy link
Member Author

Manishearth commented Jul 29, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2019

📌 Commit d996d3c has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2019

⌛ Testing commit d996d3c with merge 9043f24...
bors-servo added a commit that referenced this pull request Jul 30, 2019
@bors-servo
Auto merge of #23839 - Manishearth:end-improve, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9043f24 
Improve session test lifecycle code

Requires servo/webxr#25

Fixes #23796, hopefully

r? @asajeffrey

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23839)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing 9043f24 to master...
@bors-servo bors-servo merged commit d996d3c into servo:master Jul 30, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Intermittent timeouts in /webxr/xrSession_prevent_multiple_exclusive.https.html, /webxr/xrDevice_disconnect_ends.https.html, /webxr/xrSession_input_events_end.https.html
4 participants
@Manishearth @highfive @bors-servo @asajeffrey
You can’t perform that action at this time.