Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update euclid in servo-media and rust-webvr. #23842

Closed
wants to merge 1 commit into from
Closed

Update euclid in servo-media and rust-webvr. #23842

wants to merge 1 commit into from

Conversation

@emilio
Copy link
Member

emilio commented Jul 24, 2019 •
edited by SimonSapin

And thus finish the euclid update.

This change is Reviewable
@emilio
Update euclid in servo-media and rust-webvr.
Verified
This commit was signed with a verified signature.
emilio Emilio Cobos Álvarez
GPG key ID: E1152D0994E4BF8A Learn about signing commits
Loading status checks…
9e707b5 
And thus finish the euclid update.
@nox
Copy link
Member

nox commented Jul 24, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2019

📌 Commit 9e707b5 has been approved by nox
@highfive highfive assigned nox and unassigned jdm Jul 24, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

⌛ Testing commit 9e707b5 with merge 6988589...
bors-servo added a commit that referenced this pull request Jul 25, 2019
@bors-servo
Auto merge of #23842 - emilio:finish-euclidup, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6988589 
Update euclid in servo-media and rust-webvr.

And thus finish the euclid update.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23842)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

💔 Test failed - linux-rel-css
@CYBAI
Copy link
Collaborator

CYBAI commented Jul 25, 2019

@bors-servo retry

  • Hmm... the update is related to servo-media, not sure if the failure is related so let's retry!
  = note: /home/servo/buildbot/slave/linux-rel-wpt/build/target/release/deps/libgstreamer_gl-f443a8c6f3880ff3.rlib(gstreamer_gl-f443a8c6f3880ff3.gstreamer_gl.1q23owqq-cgu.4.rcgu.o):gstreamer_gl.1q23owqq-cgu.4:function gstreamer_gl::gl_display_wayland::_$LT$impl$u20$gstreamer_gl..auto..gl_display_wayland..GLDisplayWayland$GT$::new_with_display::h1eab92a985f184fc: error: undefined reference to 'gst_gl_display_wayland_new_with_display'
          /home/servo/buildbot/slave/linux-rel-wpt/build/target/release/deps/libgstreamer_gl-f443a8c6f3880ff3.rlib(gstreamer_gl-f443a8c6f3880ff3.gstreamer_gl.1q23owqq-cgu.4.rcgu.o):gstreamer_gl.1q23owqq-cgu.4:function gstreamer_gl::gl_display_wayland::_$LT$impl$u20$gstreamer_gl..auto..gl_display_wayland..GLDisplayWayland$GT$::new_with_display::h1eab92a985f184fc: error: undefined reference to 'gst_gl_display_wayland_get_type'
          collect2: error: ld returned 1 exit status
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

⌛ Testing commit 9e707b5 with merge 8e35773...
bors-servo added a commit that referenced this pull request Jul 25, 2019
@bors-servo
Auto merge of #23842 - emilio:finish-euclidup, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8e35773 
Update euclid in servo-media and rust-webvr.

And thus finish the euclid update.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23842)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

💔 Test failed - linux-rel-css
@CYBAI
Copy link
Collaborator

CYBAI commented Jul 25, 2019

Same failure again 👀

  = note: /home/servo/buildbot/slave/linux-rel-css/build/target/release/deps/libgstreamer_gl-f443a8c6f3880ff3.rlib(gstreamer_gl-f443a8c6f3880ff3.gstreamer_gl.1q23owqq-cgu.4.rcgu.o):gstreamer_gl.1q23owqq-cgu.4:function gstreamer_gl::gl_display_wayland::_$LT$impl$u20$gstreamer_gl..auto..gl_display_wayland..GLDisplayWayland$GT$::new_with_display::h1eab92a985f184fc: error: undefined reference to 'gst_gl_display_wayland_new_with_display'
          /home/servo/buildbot/slave/linux-rel-css/build/target/release/deps/libgstreamer_gl-f443a8c6f3880ff3.rlib(gstreamer_gl-f443a8c6f3880ff3.gstreamer_gl.1q23owqq-cgu.4.rcgu.o):gstreamer_gl.1q23owqq-cgu.4:function gstreamer_gl::gl_display_wayland::_$LT$impl$u20$gstreamer_gl..auto..gl_display_wayland..GLDisplayWayland$GT$::new_with_display::h1eab92a985f184fc: error: undefined reference to 'gst_gl_display_wayland_get_type'
          collect2: error: ld returned 1 exit status
@jdm
Copy link
Member

jdm commented Jul 25, 2019 •
edited

@ferjm @ceyusa More gstgl linking issues :(
@ceyusa
Copy link
Collaborator

ceyusa commented Jul 25, 2019

@ferjm @ceyusa More gstgl linking issues :(

I shouldn't added support for wayland without verifying its support in the bots... sorry!

What about adding features flags for the winsys to support at compilation time: x11/wayland/egl
@ferjm
Copy link
Member

ferjm commented Jul 25, 2019

Feature flags sounds good to me.

We may be able to workaround the issue by regenerating the gstreamer binaries for CI with all the required deps for gstgl to expose wayland related symbols.
@ferjm ferjm mentioned this pull request Jul 25, 2019
Merged
2 of 3 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2019

☔ The latest upstream changes (presumably #23903) made this pull request unmergeable. Please resolve the merge conflicts.
@Eijebong Eijebong mentioned this pull request Aug 11, 2019
Open
16 of 19 tasks complete
bors-servo added a commit that referenced this pull request Aug 13, 2019
@bors-servo
Auto merge of #23853 - ferjm:media.update, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
72bc245 
[WIP] Fix HTMLMediaElement seek race condition

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

This depends on servo/media#289 and it's blocked by the servo-media update issue mentioned [here](#23842 (comment))

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23853)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 13, 2019
@bors-servo
Auto merge of #23853 - ferjm:media.update, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e10efb2 
Fix HTMLMediaElement seek race condition

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

This depends on servo/media#289 and it's blocked by the servo-media update issue mentioned [here](#23842 (comment))

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23853)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 14, 2019
@bors-servo
Auto merge of #23853 - ferjm:media.update, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d7433c9 
Fix HTMLMediaElement seek race condition

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

This depends on servo/media#289 and it's blocked by the servo-media update issue mentioned [here](#23842 (comment))

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23853)
<!-- Reviewable:end -->
@ferjm
Copy link
Member

ferjm commented Aug 14, 2019

Same failure again 👀

  = note: /home/servo/buildbot/slave/linux-rel-css/build/target/release/deps/libgstreamer_gl-f443a8c6f3880ff3.rlib(gstreamer_gl-f443a8c6f3880ff3.gstreamer_gl.1q23owqq-cgu.4.rcgu.o):gstreamer_gl.1q23owqq-cgu.4:function gstreamer_gl::gl_display_wayland::_$LT$impl$u20$gstreamer_gl..auto..gl_display_wayland..GLDisplayWayland$GT$::new_with_display::h1eab92a985f184fc: error: undefined reference to 'gst_gl_display_wayland_new_with_display'
          /home/servo/buildbot/slave/linux-rel-css/build/target/release/deps/libgstreamer_gl-f443a8c6f3880ff3.rlib(gstreamer_gl-f443a8c6f3880ff3.gstreamer_gl.1q23owqq-cgu.4.rcgu.o):gstreamer_gl.1q23owqq-cgu.4:function gstreamer_gl::gl_display_wayland::_$LT$impl$u20$gstreamer_gl..auto..gl_display_wayland..GLDisplayWayland$GT$::new_with_display::h1eab92a985f184fc: error: undefined reference to 'gst_gl_display_wayland_get_type'
          collect2: error: ld returned 1 exit status

This should be fixed after #23853. @emilio could you rebase, please?
@dralley
Copy link
Contributor

dralley commented Apr 14, 2020

@emilio I think this PR can be closed now, euclid got updated at some point: https://github.com/servo/servo/blob/master/Cargo.lock#L1477-L1478
@jdm jdm closed this Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
@emilio @nox @bors-servo @CYBAI @jdm @ceyusa @ferjm @dralley @highfive
You can’t perform that action at this time.