Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hololens] More events, remove most of the statics, better shutdown #23845

Merged
merged 1 commit into from Jul 25, 2019
Merged

[hololens] More events, remove most of the statics, better shutdown #23845

merged 1 commit into from Jul 25, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Jul 24, 2019 •
edited by SimonSapin

Depends on #23831

  • Buttons are greyed out when necessary
  • Reload, Stop, Back and Fwd are properly bound
  • Servo.cpp rewritten in a much cleaner way
  • Removed most of the statics
  • Improved (but not full) shutdown

This change is Reviewable
@paulrouget paulrouget changed the title More events, remove most of the statics, better shutdown [hololens] More events, remove most of the statics, better shutdown Jul 24, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 24, 2019

r? @jdm
@highfive highfive assigned jdm and unassigned nox Jul 24, 2019
@jdm
Copy link
Member

jdm commented Jul 24, 2019

@bors-servo r+
Nice improvement! I agree that this is cleaner.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2019

📌 Commit a0155b8 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2019

☔ The latest upstream changes (presumably #23831) made this pull request unmergeable. Please resolve the merge conflicts.
@paulrouget
More events, remove most of the statics, better shutdown
Loading status checks…
d0436f1
@paulrouget paulrouget force-pushed the paulrouget:cleanup branch from a0155b8 to d0436f1 Jul 25, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 25, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

📌 Commit d0436f1 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

⌛ Testing commit d0436f1 with merge 3e90b93...
bors-servo added a commit that referenced this pull request Jul 25, 2019
@bors-servo
Auto merge of #23845 - paulrouget:cleanup, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3e90b93 
[hololens] More events, remove most of the statics, better shutdown

Depends on #23831

- Buttons are greyed out when necessary
- Reload, Stop, Back and Fwd are properly bound
- Servo.cpp rewritten in a much cleaner way
- Removed most of the statics
- Improved (but not full) shutdown

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23845)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 3e90b93 to master...
@bors-servo bors-servo merged commit d0436f1 into servo:master Jul 25, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@paulrouget @jdm @bors-servo @nox @highfive
You can’t perform that action at this time.