Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the event loop waker into WebXR #23847

Merged
merged 1 commit into from Jul 25, 2019
Merged

Pass the event loop waker into WebXR #23847

merged 1 commit into from Jul 25, 2019

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jul 24, 2019 •
edited by SimonSapin

This PR passes the event loop waker into webxr so it can wake the main thread up when needed.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #23796
  • These changes do not require tests because existing tests do the job

This change is Reviewable
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-main-thread-waker branch from 02d2d5f to 6f42ecf Jul 24, 2019
@jdm
jdm approved these changes Jul 24, 2019
View changes
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-main-thread-waker branch from 6f42ecf to 08f2061 Jul 24, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 24, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2019

📌 Commit 08f2061 has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm Jul 24, 2019
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-main-thread-waker branch from 08f2061 to b3447f8 Jul 24, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 24, 2019 

error[E0407]: method `clone` is not a member of trait `EventLoopWaker`
  --> components/net/tests/main.rs:70:13
   |
70 | /             fn clone(&self) -> Box<dyn EventLoopWaker + Send> {
71 | |                 Box::new(DummyEventLoopWaker {})
72 | |             }
   | |_____________^ not a member of trait `EventLoopWaker`

Serves me right for renaming a method. @bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2019

📌 Commit b3447f8 has been approved by jdm
asajeffrey added a commit to asajeffrey/servo that referenced this pull request Jul 25, 2019
@asajeffrey
PR servo#23847
2342978
@asajeffrey asajeffrey mentioned this pull request Jul 25, 2019
Merged
3 of 3 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

⌛ Testing commit b3447f8 with merge 7a511c5...
bors-servo added a commit that referenced this pull request Jul 25, 2019
@bors-servo
Auto merge of #23847 - asajeffrey:webxr-main-thread-waker, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7a511c5 
Pass the event loop waker into WebXR

<!-- Please describe your changes on the following line: -->

This PR passes the event loop waker into webxr so it can wake the main thread up when needed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23796
- [X] These changes do not require tests because existing tests do the job

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23847)
<!-- Reviewable:end -->
@asajeffrey
Pass the event loop waker into WebXR
Loading status checks…
701256d
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-main-thread-waker branch from b3447f8 to 701256d Jul 25, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 25, 2019

Didn't catch all the impls of EventLoopWaker. @bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

📌 Commit 701256d has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

⌛ Testing commit 701256d with merge e6a6e3a...
bors-servo added a commit that referenced this pull request Jul 25, 2019
@bors-servo
Auto merge of #23847 - asajeffrey:webxr-main-thread-waker, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e6a6e3a 
Pass the event loop waker into WebXR

<!-- Please describe your changes on the following line: -->

This PR passes the event loop waker into webxr so it can wake the main thread up when needed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23796
- [X] These changes do not require tests because existing tests do the job

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23847)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jul 25, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

⌛ Testing commit 701256d with merge ad82d67...
bors-servo added a commit that referenced this pull request Jul 25, 2019
@bors-servo
Auto merge of #23847 - asajeffrey:webxr-main-thread-waker, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ad82d67 
Pass the event loop waker into WebXR

<!-- Please describe your changes on the following line: -->

This PR passes the event loop waker into webxr so it can wake the main thread up when needed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23796
- [X] These changes do not require tests because existing tests do the job

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23847)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing ad82d67 to master...
@bors-servo bors-servo merged commit 701256d into servo:master Jul 25, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
A-xr-zomg
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Intermittent timeouts in /webxr/xrSession_prevent_multiple_exclusive.https.html, /webxr/xrDevice_disconnect_ends.https.html, /webxr/xrSession_input_events_end.https.html
5 participants
@asajeffrey @bors-servo @jdm @ferjm @highfive
You can’t perform that action at this time.