Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace use of callbacks in webxr by channels #23848
Merged
Conversation
highfive
commented
Jul 25, 2019
|
Heads up! This PR modifies the following files:
|
|
Depends on #23847 and servo/webxr#29 |
|
r? @Manishearth |
asajeffrey
changed the title
|
|
asajeffrey
added a commit
to asajeffrey/servo
that referenced
this pull request
Jul 25, 2019
asajeffrey
force-pushed the
asajeffrey:webxr-moar-channels
branch
2 times, most recently
from
9efcc74
to
1cbf512
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 25, 2019
Replace use of callbacks in webxr by channels <!-- Please describe your changes on the following line: --> Use senders rather than callbacks in webxr. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's an internal change <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23848) <!-- Reviewable:end -->
|
|
|
asajeffrey
force-pushed the
asajeffrey:webxr-moar-channels
branch
from
1cbf512
to
65a26ad
bors-servo
added a commit
that referenced
this pull request
Jul 27, 2019
Replace use of callbacks in webxr by channels <!-- Please describe your changes on the following line: --> Use senders rather than callbacks in webxr. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's an internal change <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23848) <!-- Reviewable:end -->
Note that it's #23290 intermittent failure. |
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 27, 2019
Replace use of callbacks in webxr by channels <!-- Please describe your changes on the following line: --> Use senders rather than callbacks in webxr. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's an internal change <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23848) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 27, 2019
Replace use of callbacks in webxr by channels <!-- Please describe your changes on the following line: --> Use senders rather than callbacks in webxr. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's an internal change <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23848) <!-- Reviewable:end -->
|
|
This was referenced Jul 27, 2019
SimonSapin
added a commit
that referenced
this pull request
Jul 28, 2019
This backs out commit 133a17e / PR #23848 because it relies on a git branch that was apparently removed: ``` $ cargo fetch Updating git repository `https://github.com/asajeffrey/webxr` error: failed to resolve patches for `https://github.com/servo/webxr` Caused by: failed to load source for a dependency on `webxr` Caused by: Unable to update https://github.com/asajeffrey/webxr?branch=optional-glsync#da820a3a Caused by: revspec 'da820a3ab266fce07c9a8abee3e6e9231cb93ec5' not found; class=Reference (4); code=NotFound (-3) ```
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2019
Revert "Replace use of callbacks in webxr by channels" This backs out commit 133a17e / PR #23848 because it relies on a git branch that was apparently removed: ``` $ cargo fetch Updating git repository `https://github.com/asajeffrey/webxr` error: failed to resolve patches for `https://github.com/servo/webxr` Caused by: failed to load source for a dependency on `webxr` Caused by: Unable to update https://github.com/asajeffrey/webxr?branch=optional-glsync#da820a3a Caused by: revspec 'da820a3ab266fce07c9a8abee3e6e9231cb93ec5' not found; class=Reference (4); code=NotFound (-3) ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23874) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2019
Revert "Replace use of callbacks in webxr by channels" This backs out commit 133a17e / PR #23848 because it relies on a git branch that was apparently removed: ``` $ cargo fetch Updating git repository `https://github.com/asajeffrey/webxr` error: failed to resolve patches for `https://github.com/servo/webxr` Caused by: failed to load source for a dependency on `webxr` Caused by: Unable to update https://github.com/asajeffrey/webxr?branch=optional-glsync#da820a3a Caused by: revspec 'da820a3ab266fce07c9a8abee3e6e9231cb93ec5' not found; class=Reference (4); code=NotFound (-3) ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23874) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJul 25, 2019
•
edited by SimonSapin
Use senders rather than callbacks in webxr.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is