Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix HTMLMediaElement seek race condition #23853
Merged
Conversation
highfive
commented
Jul 25, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 25, 2019
|
|
|
@SimonSapin does the last commit ignoring the duplicated url crate and a couple of its dependencies look ok to you? |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Aug 13, 2019
[WIP] Fix HTMLMediaElement seek race condition - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) This depends on servo/media#289 and it's blocked by the servo-media update issue mentioned [here](#23842 (comment)) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23853) <!-- Reviewable:end -->
|
r? @ceyusa |
ferjm
changed the title
|
|
|
r+ |
|
@bors-servo r=ceyusa |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 13, 2019
Fix HTMLMediaElement seek race condition - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) This depends on servo/media#289 and it's blocked by the servo-media update issue mentioned [here](#23842 (comment)) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23853) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Aug 14, 2019
Fix HTMLMediaElement seek race condition - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) This depends on servo/media#289 and it's blocked by the servo-media update issue mentioned [here](#23842 (comment)) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23853) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJul 25, 2019
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis depends on servo/media#289 and it's blocked by the servo-media update issue mentioned here
This change is