Various UWP GStreamer improvements #23863

jdm · 2019-07-26T14:12:18Z

There are a number of positive changes in these commits:

we successfully load GStreamer plugins in ARM64 UWP builds
we correctly link the ARM64 ANGLE libraries when appropriate
it is no longer necessary to manually set the LIB environment variable on Windows
we automatically download and link against UWP-friendly GStreamer binaries when building with --uwp
the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them
the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #23742
There are tests for these changes

This change is

highfive · 2019-07-26T14:12:23Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/command_base.py, python/servo/packages.py, python/servo/build_commands.py

ferjm · 2019-07-26T14:32:38Z

LGTM. Thanks!

@bors-servo r+

bors-servo · 2019-07-26T14:32:39Z

📌 Commit 621a203 has been approved by ferjm


        Auto merge of #23863 - jdm:gstreamer-uwp, r=ferjm

Various UWP GStreamer improvements There are a number of positive changes in these commits: * we successfully load GStreamer plugins in ARM64 UWP builds * we correctly link the ARM64 ANGLE libraries when appropriate * it is no longer necessary to manually set the LIB environment variable on Windows * we automatically download and link against UWP-friendly GStreamer binaries when building with `--uwp` * the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them * the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23742 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23863)

bors-servo · 2019-07-26T15:29:11Z

⌛ Testing commit 621a203 with merge c31b47c...

jdm · 2019-07-26T17:28:57Z

@bors-servo r=ferjm

bors-servo · 2019-07-26T17:28:57Z

📌 Commit e982de1 has been approved by ferjm

bors-servo · 2019-07-26T17:29:02Z

⌛ Testing commit e982de1 with merge 5369df5...


        Auto merge of #23863 - jdm:gstreamer-uwp, r=ferjm

Various UWP GStreamer improvements There are a number of positive changes in these commits: * we successfully load GStreamer plugins in ARM64 UWP builds * we correctly link the ARM64 ANGLE libraries when appropriate * it is no longer necessary to manually set the LIB environment variable on Windows * we automatically download and link against UWP-friendly GStreamer binaries when building with `--uwp` * the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them * the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23742 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23863)

jdm · 2019-07-26T18:44:09Z

@bors-servo r=ferjm

bors-servo · 2019-07-26T18:44:10Z

📌 Commit 03e5f86 has been approved by ferjm

bors-servo · 2019-07-26T18:44:15Z

⌛ Testing commit 03e5f86 with merge d76c0ec...


        Auto merge of #23863 - jdm:gstreamer-uwp, r=ferjm

Various UWP GStreamer improvements There are a number of positive changes in these commits: * we successfully load GStreamer plugins in ARM64 UWP builds * we correctly link the ARM64 ANGLE libraries when appropriate * it is no longer necessary to manually set the LIB environment variable on Windows * we automatically download and link against UWP-friendly GStreamer binaries when building with `--uwp` * the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them * the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23742 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23863)

bors-servo · 2019-07-26T19:27:50Z

💔 Test failed - linux-rel-wpt

jdm · 2019-07-26T19:34:08Z

@bors-servo retry

#22955

jdm · 2019-07-26T19:57:31Z

@bors-servo try=windows

bors-servo · 2019-07-26T19:57:35Z

⌛ Trying commit 320667f with merge 27d369b...


        Auto merge of #23863 - jdm:gstreamer-uwp, r=<try>

Various UWP GStreamer improvements There are a number of positive changes in these commits: * we successfully load GStreamer plugins in ARM64 UWP builds * we correctly link the ARM64 ANGLE libraries when appropriate * it is no longer necessary to manually set the LIB environment variable on Windows * we automatically download and link against UWP-friendly GStreamer binaries when building with `--uwp` * the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them * the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23742 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23863)

bors-servo · 2019-07-26T21:05:47Z

💔 Test failed - status-taskcluster


        Vendor UWP GStreamer binaries.


        Load GStreamer plugins in UWP builds.


        Add more DLLs to UWP app.


        Fix CI builds.


        Load GStreamer plugins on Windows arm64.


        Build with UWP configuration on CI.

jdm · 2019-07-27T13:59:04Z

@bors-servo r=ferjm

bors-servo · 2019-07-27T13:59:05Z

📌 Commit 81914e5 has been approved by ferjm

bors-servo · 2019-07-27T16:03:13Z

⌛ Testing commit 81914e5 with merge b9b0176...


        Auto merge of #23863 - jdm:gstreamer-uwp, r=ferjm

Various UWP GStreamer improvements There are a number of positive changes in these commits: * we successfully load GStreamer plugins in ARM64 UWP builds * we correctly link the ARM64 ANGLE libraries when appropriate * it is no longer necessary to manually set the LIB environment variable on Windows * we automatically download and link against UWP-friendly GStreamer binaries when building with `--uwp` * the use of vcruntime140.dll, msvcp140.dll and api-ms-win-crt-runtime-l1-1-0.dll in the UWP application has been removed and the build does not repackage them * the set of base supporting GStreamer DLLs has been expanded to allow the gstlibav plugin to load correctly ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23742 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23863)

bors-servo · 2019-07-27T18:41:31Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: ferjm
Pushing b9b0176 to master...

highfive assigned ferjm Jul 26, 2019

highfive added the S-awaiting-review label Jul 26, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 26, 2019

highfive added S-awaiting-review and removed S-awaiting-merge labels Jul 26, 2019

jdm force-pushed the jdm:gstreamer-uwp branch from 782b941 to e982de1 Jul 26, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 26, 2019

jdm force-pushed the jdm:gstreamer-uwp branch from e982de1 to 03e5f86 Jul 26, 2019

highfive added S-awaiting-review and removed S-awaiting-merge labels Jul 26, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 26, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 26, 2019

highfive added S-awaiting-review and removed S-tests-failed labels Jul 26, 2019

highfive added the S-tests-failed label Jul 26, 2019

jdm added 6 commits Jul 25, 2019

Vendor UWP GStreamer binaries.

5d3d766

Load GStreamer plugins in UWP builds.

bcbd425

Add more DLLs to UWP app.

817a7fe

Fix CI builds.

9336931

Load GStreamer plugins on Windows arm64.

e9a7544

Build with UWP configuration on CI.

Loading status checks…

81914e5

jdm force-pushed the jdm:gstreamer-uwp branch from 320667f to 81914e5 Jul 27, 2019

highfive removed the S-tests-failed label Jul 27, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 27, 2019

bors-servo merged commit 81914e5 into servo:master Jul 27, 2019
2 of 3 checks passed

2 of 3 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jul 27, 2019

servo / servo

Various UWP GStreamer improvements #23863

Various UWP GStreamer improvements #23863

jdm commented Jul 26, 2019 •

edited by SimonSapin

highfive commented Jul 26, 2019

ferjm commented Jul 26, 2019

bors-servo commented Jul 26, 2019

bors-servo commented Jul 26, 2019

jdm commented Jul 26, 2019

bors-servo commented Jul 26, 2019

bors-servo commented Jul 26, 2019

jdm commented Jul 26, 2019

bors-servo commented Jul 26, 2019

bors-servo commented Jul 26, 2019

bors-servo commented Jul 26, 2019

jdm commented Jul 26, 2019

jdm commented Jul 26, 2019

bors-servo commented Jul 26, 2019

bors-servo commented Jul 26, 2019

jdm commented Jul 27, 2019

bors-servo commented Jul 27, 2019

bors-servo commented Jul 27, 2019

bors-servo commented Jul 27, 2019

servo / servo

Join GitHub today

Various UWP GStreamer improvements #23863

Various UWP GStreamer improvements #23863

Conversation

jdm commented Jul 26, 2019 • edited by SimonSapin

highfive commented Jul 26, 2019

ferjm commented Jul 26, 2019

bors-servo commented Jul 26, 2019

bors-servo commented Jul 26, 2019

jdm commented Jul 26, 2019

bors-servo commented Jul 26, 2019

bors-servo commented Jul 26, 2019

jdm commented Jul 26, 2019

bors-servo commented Jul 26, 2019

bors-servo commented Jul 26, 2019

bors-servo commented Jul 26, 2019

jdm commented Jul 26, 2019

jdm commented Jul 26, 2019

bors-servo commented Jul 26, 2019

bors-servo commented Jul 26, 2019

jdm commented Jul 27, 2019

bors-servo commented Jul 27, 2019

bors-servo commented Jul 27, 2019

bors-servo commented Jul 27, 2019

jdm commented Jul 26, 2019 •

edited by SimonSapin