Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWhen using the WebGL external image API, use sync calls if we happen to be on the WebGL thread #23868
Conversation
|
This is getting GL errors when I run it locally with which is why I've labelled it DRAFT for now. |
…to be on the WebGL thread
asajeffrey
force-pushed the
asajeffrey:webgl-if-used-on-main-thread-use-directly-do-not-pass-go
branch
from
fe26b88
to
0178fca
|
@bors-servo r+ p=10 |
|
|
Closed
bors-servo
added a commit
that referenced
this pull request
Jul 27, 2019
…rectly-do-not-pass-go, r=jdm When using the WebGL external image API, use sync calls if we happen to be on the WebGL thread <!-- Please describe your changes on the following line: --> When using the external image API, use synchronous method calls if we happen to be on the same thread as WebGL. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23832 hopefully - [x] These changes do not require tests because it's fixing a deadlock <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23868) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJul 26, 2019
•
edited by SimonSapin
When using the external image API, use synchronous method calls if we happen to be on the same thread as WebGL.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is