Add PerformanceResourceTiming:TimingAllowCheck #23873

RestitutorOrbis · 2019-07-28T02:05:17Z

Added timing allow check to http_loader.rs in fn http_network_fetch.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #21270

Things to Do

Map header values from Timing-Allow-Origin to URL types using Url::Parse
Check equality of those header URL origin with the origin in question
Just use url instead of res.origin
Change .set_attribute(ResourceAttribute::RedirectStart(0)) to .set_attribute(ResourceAttribute::RedirectStart(RedirectStartValue::Zero))
Change .set_attribute(ResourceAttribute::RedirectEnd(0)) to .set_attribute(ResourceAttribute::RedirectEnd(RedirectEndValue::Zero))
Figure out how to set DomainLookupStart, RequestStart, and ResponseStart without directly passing value as part of enum
Figure out how to handle lack of DomainLookupEnd (#21260) and SecureConnectionStart (#21268)
add a flag to ResourceFetchTiming that indicates if the timing check passed, and only update timing attributes if that flag is false
add function to mark timing test as failed and set all attributes to 0
resolve compile error regarding move of header_strings variable
resolve URL parse errors that appear during test execution
~~Fix /resource-timing/crossorigin-sandwich-no-TAO.sub.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html)
~~Fix /resource-timing/crossorigin-sandwich-TAO.sub.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html)
~~Fix /resource-timing/resource-reload-TAO.sub.html~~ (Get TIMEOUT, fails on Firefox too?)
~~Fix /resource-timing/resource_TAO_cross_origin_redirect_chain.html~~ (Problem seems to lie in loading the iFrame, when the request is made, the URL attached to the PerformanceResourceTiming interface is the initial URL set on the iFrame instead of the URL that is ultimately loaded)
~~Fix resource-timing/resource_TAO_multi_wildcard.html~~ (Doesn't work because IMG element doesn't generate HTTP request with Origin field)
Fix /resource-timing/resource_TAO_match_origin.htm
Fix /resource-timing/resource_TAO_match_wildcard.htm
Fix /resource-timing/resource_TAO_multi.htm
Fix /resource-timing/resource_TAO_wildcard.htm
Fix /resource-timing/resource_TAO_zero.htm
Fix /resource-timing/resource_TAO_null.htm
Fix /resource-timing/resource_TAO_origin.htm (tests for responseStart and domainLookupEnd fail because #21260 and #21271 haven't been resolved)
Fix /resource-timing/resource_TAO_space.htm
Fix /resource-timing/resource_TAO_origin_uppercase.htm
~~Fix /resource-timing/resource_timing_TAO_cross_origin_redirect.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html)
~~Fix /resource-timing/TAO-case-insensitive-null-opaque-origin.sub.html~~ (TIMEOUT, doesn't seem to parse iFrame SRC correctly? There doesn't seem to be any sign that it makes a request to TAOResponse.py)
Fix /resource-timing/TAO-crossorigin-port.sub.html
~~Fix /resource-timing/TAO-null-opaque-origin.sub.html~~ (Refer to /resource-timing/TAO-crossorigin-port.sub.html)
/navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in.html
/navigation-timing/nav2_test_document_open.html
/navigation-timing/nav2_test_frame_removed.html
/performance-timeline/not-clonable.html
/navigation-timing/nav2_test_redirect_xserver.html
/resource-timing/resource_connection_reuse.https.html
/resource-timing/resource_reparenting.html
/resource-timing/resource_connection_reuse.html
/resource-timing/resource_script_types.html
/resource-timing/idlharness.any.html
/resource-timing/clear_resource_timing_functionality.html
/resource-timing/idlharness.any.worker.html
/resource-timing/resource_cached.htm
/resource-timing/resource_connection_reuse_mixed_content_redirect.html
/resource-timing/resource_connection_reuse_mixed_content.html
/resource-timing/resource_timing_buffer_full_when_shrink_buffer_size.html
/navigation-timing/idlharness.window.html
/navigation-timing/nav2_test_navigate_iframe.html
/navigation-timing/nav2_test_navigate_within_document.html
/resource-timing/resource_reuse.sub.html
/navigation-timing/nav2_test_instance_accessible_from_the_start.html
/resource-timing/resource_dedicated_worker.html
/navigation-timing/unload-event-same-origin-check.html
/navigation-timing/nav2_test_navigation_type_backforward.html

There are tests for these changes OR
These changes do not require tests because ___

This change is

highfive · 2019-07-28T02:05:25Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

highfive · 2019-07-28T02:05:26Z

Heads up! This PR modifies the following files:

@KiChjang: components/net/http_loader.rs

highfive · 2019-07-28T02:05:28Z

Warning

These commits modify net code, but no tests are modified. Please consider adding a test!

jdm · 2019-07-29T03:00:31Z

@RestitutorOrbis What do you need help with?

RestitutorOrbis · 2019-07-31T03:58:48Z

@jdm At the moment, I'm unsure of how to handle the lack of DomainLookupEnd, and SecureConnectionStart. Do I need to do those issues first or is it alright if I leave a todo with regard to that? Also, How do I handle setting DomainLookupStart, RequestStart, and ResponseStart? They don't seem to have Enums associated with them.

jdm · 2019-08-07T14:01:51Z

@RestitutorOrbis Yes, you can leave the missing fields as TODO comments while they don't exist. Rather than relying on enums, I would recommend adding a mark_failed_timing_check method which sets the timing check member to false and sets all other members to 0.

jdm · 2019-08-15T18:43:56Z

components/net_traits/lib.rs

-                    if self.redirect_start == 0 {
-                        self.redirect_start = self.fetch_start
-                    }
+        if self.timing_check_passed {


I would suggest this:

if !self.timing_check_passed { return; }

jdm · 2019-08-15T18:43:56Z

components/net/http_loader.rs

+            .timing
+            .lock()
+            .unwrap()
+            .set_attribute(ResourceAttribute::TimingCheckPassed);


We should call mark_timing_check_failed directly here instead of using set_attribute. That means we can remove the new ResourceAttribute value as well.

But if we remove the ResourceAttribute value, then we can't have an early return in set_attribute and we need that early return in case it tries to set it later, right?

I'm not sure I understand the issue. mark_timing_check_failed will set the timing_check_passed member appropriately, and set_attribute can continue to check timing_check_passed.

Yeah, you're right. I was mistaken.

jdm · 2019-08-15T18:43:56Z

components/net/http_loader.rs

+        .collect();
+    let wildcard_present = header_strings
+        .iter()
+        .fold(false, |acc, header_str| acc || *header_str == "*");


I think any(|header| *header == "*") instead of fold is easier to read.

jdm · 2019-08-15T18:43:56Z

components/net/http_loader.rs

+        .iter()
+        .map(|header_string| ServoUrl::parse(header_string))
+        .filter(|header_url| header_url.is_ok())
+        .map(|header_url| header_url.unwrap().into_url())


.filter_map(|header| ServoUrl::parse(header).ok().map(|u| u.into_url())

jdm · 2019-08-15T18:43:56Z

components/net/http_loader.rs

+        .map(|header_string| ServoUrl::parse(header_string))
+        .filter(|header_url| header_url.is_ok())
+        .map(|header_url| header_url.unwrap().into_url())
+        .fold(false, |acc, header_url| {


.any(|header_url| header_url.origin() == url.as_url().origin())
I don't think the cloned_url is necessary if you don't use fold.

RestitutorOrbis · 2019-09-03T20:46:25Z

Progress Update:
I've been working to get the tests working. I've noticed that the values I set in the mark_timing_check_failed don't seem to be passed onto the JS interface as the tests are reporting NaN values, I haven't had much luck getting a deeper understanding of whats going on as I'm still getting used to the workflow with Mach. Hope to report good news soon!

jdm · 2019-09-04T15:03:25Z

components/net_traits/lib.rs

@@ -488,6 +489,7 @@ impl ResourceFetchTiming {
    pub fn new(timing_type: ResourceTimingType) -> ResourceFetchTiming {
        ResourceFetchTiming {
            timing_type: timing_type,
+            timing_check_passed: false,


This should be initialized to true.

RestitutorOrbis · 2019-09-24T03:37:40Z

@bors-servo try=wpt

bors-servo · 2019-09-24T03:37:41Z

@RestitutorOrbis: 🔑 Insufficient privileges: not in try users

RestitutorOrbis · 2019-09-24T18:03:05Z

@jdm Can you re-run the taskcluster task and @bors-servo try=wpt. The taskcluster fails on a git reset which I assume isn't likely to recur.

bors-servo · 2019-09-24T18:03:06Z

@RestitutorOrbis: 🔑 Insufficient privileges: not in try users

jdm · 2019-09-24T18:12:37Z

@bors-servo try=wpt


        Auto merge of #23873 - RestitutorOrbis:jn-add-tao, r=<try>

Add PerformanceResourceTiming:TimingAllowCheck Added timing allow check to http_loader.rs in `fn http_network_fetch`.  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21270 ### Things to Do - [x] Map header values from Timing-Allow-Origin to URL types using [Url::Parse](https://docs.rs/url/2.0.0/url/) - [x] Check equality of those header URL origin with the origin in question - [x] Just use url instead of `res.origin` - [x] Change `.set_attribute(ResourceAttribute::RedirectStart(0))` to `.set_attribute(ResourceAttribute::RedirectStart(RedirectStartValue::Zero))` - [x] Change `.set_attribute(ResourceAttribute::RedirectEnd(0))` to `.set_attribute(ResourceAttribute::RedirectEnd(RedirectEndValue::Zero))` - [x] Figure out how to set DomainLookupStart, RequestStart, and ResponseStart without directly passing value as part of enum - [x] Figure out how to handle lack of DomainLookupEnd (#21260) and SecureConnectionStart (#21268) - [x] add a flag to ResourceFetchTiming that indicates if the timing check passed, and only update timing attributes if that flag is false - [x] add function to mark timing test as failed and set all attributes to 0 - [x] resolve compile error regarding move of header_strings variable - [x] resolve URL parse errors that appear during test execution - [x] ~~Fix /resource-timing/crossorigin-sandwich-no-TAO.sub.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html) - [x] ~~Fix /resource-timing/crossorigin-sandwich-TAO.sub.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html) - [x] ~~Fix /resource-timing/resource-reload-TAO.sub.html~~ (Get TIMEOUT, fails on Firefox too?) - [x] ~~Fix /resource-timing/resource_TAO_cross_origin_redirect_chain.html~~ (Problem seems to lie in loading the iFrame, when the request is made, the URL attached to the PerformanceResourceTiming interface is the initial URL set on the iFrame instead of the URL that is ultimately loaded) - [x] ~~Fix resource-timing/resource_TAO_multi_wildcard.html~~ (Doesn't work because IMG element doesn't generate HTTP request with Origin field) - [x] Fix /resource-timing/resource_TAO_match_origin.htm - [x] Fix /resource-timing/resource_TAO_match_wildcard.htm - [x] Fix /resource-timing/resource_TAO_multi.htm - [x] Fix /resource-timing/resource_TAO_wildcard.htm - [x] Fix /resource-timing/resource_TAO_zero.htm - [x] Fix /resource-timing/resource_TAO_null.htm - [x] Fix /resource-timing/resource_TAO_origin.htm (tests for responseStart and domainLookupEnd fail because #21260 and #21271 haven't been resolved) - [x] Fix /resource-timing/resource_TAO_space.htm - [x] Fix /resource-timing/resource_TAO_origin_uppercase.htm - [x] ~~Fix /resource-timing/resource_timing_TAO_cross_origin_redirect.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html) - [x] ~~Fix /resource-timing/TAO-case-insensitive-null-opaque-origin.sub.html~~ (TIMEOUT, doesn't seem to parse iFrame SRC correctly? There doesn't seem to be any sign that it makes a request to TAOResponse.py) - [x] Fix /resource-timing/TAO-crossorigin-port.sub.html - [x] ~~Fix /resource-timing/TAO-null-opaque-origin.sub.html~~ (Refer to /resource-timing/TAO-crossorigin-port.sub.html) - [x] /navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in.html - [x] /navigation-timing/nav2_test_document_open.html - [x] /navigation-timing/nav2_test_frame_removed.html - [x] /performance-timeline/not-clonable.html - [x] /navigation-timing/nav2_test_redirect_xserver.html - [x] /resource-timing/resource_connection_reuse.https.html - [x] /resource-timing/resource_reparenting.html - [x] /resource-timing/resource_connection_reuse.html - [x] /resource-timing/resource_script_types.html - [x] /resource-timing/idlharness.any.html - [x] /resource-timing/clear_resource_timing_functionality.html - [x] /resource-timing/idlharness.any.worker.html - [x] /resource-timing/resource_cached.htm - [x] /resource-timing/resource_connection_reuse_mixed_content_redirect.html - [x] /resource-timing/resource_connection_reuse_mixed_content.html - [x] /resource-timing/resource_timing_buffer_full_when_shrink_buffer_size.html - [x] /navigation-timing/idlharness.window.html - [x] /navigation-timing/nav2_test_navigate_iframe.html - [x] /navigation-timing/nav2_test_navigate_within_document.html - [x] /resource-timing/resource_reuse.sub.html - [x] /navigation-timing/nav2_test_instance_accessible_from_the_start.html - [x] /resource-timing/resource_dedicated_worker.html - [x] /navigation-timing/unload-event-same-origin-check.html - [x] /navigation-timing/nav2_test_navigation_type_backforward.html  - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23873)

bors-servo · 2019-09-24T18:12:42Z

⌛ Trying commit 63adf66 with merge c1014de...

bors-servo · 2019-09-24T18:53:53Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

jdm · 2019-09-24T18:58:17Z

@bors-servo r+

bors-servo · 2019-09-24T18:58:18Z

📌 Commit 63adf66 has been approved by jdm

bors-servo · 2019-09-24T20:02:02Z

⌛ Testing commit 63adf66 with merge 7f48e93...


        Auto merge of #23873 - RestitutorOrbis:jn-add-tao, r=jdm

Add PerformanceResourceTiming:TimingAllowCheck Added timing allow check to http_loader.rs in `fn http_network_fetch`.  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21270 ### Things to Do - [x] Map header values from Timing-Allow-Origin to URL types using [Url::Parse](https://docs.rs/url/2.0.0/url/) - [x] Check equality of those header URL origin with the origin in question - [x] Just use url instead of `res.origin` - [x] Change `.set_attribute(ResourceAttribute::RedirectStart(0))` to `.set_attribute(ResourceAttribute::RedirectStart(RedirectStartValue::Zero))` - [x] Change `.set_attribute(ResourceAttribute::RedirectEnd(0))` to `.set_attribute(ResourceAttribute::RedirectEnd(RedirectEndValue::Zero))` - [x] Figure out how to set DomainLookupStart, RequestStart, and ResponseStart without directly passing value as part of enum - [x] Figure out how to handle lack of DomainLookupEnd (#21260) and SecureConnectionStart (#21268) - [x] add a flag to ResourceFetchTiming that indicates if the timing check passed, and only update timing attributes if that flag is false - [x] add function to mark timing test as failed and set all attributes to 0 - [x] resolve compile error regarding move of header_strings variable - [x] resolve URL parse errors that appear during test execution - [x] ~~Fix /resource-timing/crossorigin-sandwich-no-TAO.sub.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html) - [x] ~~Fix /resource-timing/crossorigin-sandwich-TAO.sub.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html) - [x] ~~Fix /resource-timing/resource-reload-TAO.sub.html~~ (Get TIMEOUT, fails on Firefox too?) - [x] ~~Fix /resource-timing/resource_TAO_cross_origin_redirect_chain.html~~ (Problem seems to lie in loading the iFrame, when the request is made, the URL attached to the PerformanceResourceTiming interface is the initial URL set on the iFrame instead of the URL that is ultimately loaded) - [x] ~~Fix resource-timing/resource_TAO_multi_wildcard.html~~ (Doesn't work because IMG element doesn't generate HTTP request with Origin field) - [x] Fix /resource-timing/resource_TAO_match_origin.htm - [x] Fix /resource-timing/resource_TAO_match_wildcard.htm - [x] Fix /resource-timing/resource_TAO_multi.htm - [x] Fix /resource-timing/resource_TAO_wildcard.htm - [x] Fix /resource-timing/resource_TAO_zero.htm - [x] Fix /resource-timing/resource_TAO_null.htm - [x] Fix /resource-timing/resource_TAO_origin.htm (tests for responseStart and domainLookupEnd fail because #21260 and #21271 haven't been resolved) - [x] Fix /resource-timing/resource_TAO_space.htm - [x] Fix /resource-timing/resource_TAO_origin_uppercase.htm - [x] ~~Fix /resource-timing/resource_timing_TAO_cross_origin_redirect.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html) - [x] ~~Fix /resource-timing/TAO-case-insensitive-null-opaque-origin.sub.html~~ (TIMEOUT, doesn't seem to parse iFrame SRC correctly? There doesn't seem to be any sign that it makes a request to TAOResponse.py) - [x] Fix /resource-timing/TAO-crossorigin-port.sub.html - [x] ~~Fix /resource-timing/TAO-null-opaque-origin.sub.html~~ (Refer to /resource-timing/TAO-crossorigin-port.sub.html) - [x] /navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in.html - [x] /navigation-timing/nav2_test_document_open.html - [x] /navigation-timing/nav2_test_frame_removed.html - [x] /performance-timeline/not-clonable.html - [x] /navigation-timing/nav2_test_redirect_xserver.html - [x] /resource-timing/resource_connection_reuse.https.html - [x] /resource-timing/resource_reparenting.html - [x] /resource-timing/resource_connection_reuse.html - [x] /resource-timing/resource_script_types.html - [x] /resource-timing/idlharness.any.html - [x] /resource-timing/clear_resource_timing_functionality.html - [x] /resource-timing/idlharness.any.worker.html - [x] /resource-timing/resource_cached.htm - [x] /resource-timing/resource_connection_reuse_mixed_content_redirect.html - [x] /resource-timing/resource_connection_reuse_mixed_content.html - [x] /resource-timing/resource_timing_buffer_full_when_shrink_buffer_size.html - [x] /navigation-timing/idlharness.window.html - [x] /navigation-timing/nav2_test_navigate_iframe.html - [x] /navigation-timing/nav2_test_navigate_within_document.html - [x] /resource-timing/resource_reuse.sub.html - [x] /navigation-timing/nav2_test_instance_accessible_from_the_start.html - [x] /resource-timing/resource_dedicated_worker.html - [x] /navigation-timing/unload-event-same-origin-check.html - [x] /navigation-timing/nav2_test_navigation_type_backforward.html  - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23873)

bors-servo · 2019-09-24T22:12:23Z

💔 Test failed - status-taskcluster

jdm · 2019-09-24T22:13:09Z

@bors-servo retry

#23290

bors-servo · 2019-09-24T23:11:26Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2019-09-24T23:11:30Z

⌛ Testing commit 63adf66 with merge e6b271d...


        Auto merge of #23873 - RestitutorOrbis:jn-add-tao, r=jdm

Add PerformanceResourceTiming:TimingAllowCheck Added timing allow check to http_loader.rs in `fn http_network_fetch`.  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21270 ### Things to Do - [x] Map header values from Timing-Allow-Origin to URL types using [Url::Parse](https://docs.rs/url/2.0.0/url/) - [x] Check equality of those header URL origin with the origin in question - [x] Just use url instead of `res.origin` - [x] Change `.set_attribute(ResourceAttribute::RedirectStart(0))` to `.set_attribute(ResourceAttribute::RedirectStart(RedirectStartValue::Zero))` - [x] Change `.set_attribute(ResourceAttribute::RedirectEnd(0))` to `.set_attribute(ResourceAttribute::RedirectEnd(RedirectEndValue::Zero))` - [x] Figure out how to set DomainLookupStart, RequestStart, and ResponseStart without directly passing value as part of enum - [x] Figure out how to handle lack of DomainLookupEnd (#21260) and SecureConnectionStart (#21268) - [x] add a flag to ResourceFetchTiming that indicates if the timing check passed, and only update timing attributes if that flag is false - [x] add function to mark timing test as failed and set all attributes to 0 - [x] resolve compile error regarding move of header_strings variable - [x] resolve URL parse errors that appear during test execution - [x] ~~Fix /resource-timing/crossorigin-sandwich-no-TAO.sub.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html) - [x] ~~Fix /resource-timing/crossorigin-sandwich-TAO.sub.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html) - [x] ~~Fix /resource-timing/resource-reload-TAO.sub.html~~ (Get TIMEOUT, fails on Firefox too?) - [x] ~~Fix /resource-timing/resource_TAO_cross_origin_redirect_chain.html~~ (Problem seems to lie in loading the iFrame, when the request is made, the URL attached to the PerformanceResourceTiming interface is the initial URL set on the iFrame instead of the URL that is ultimately loaded) - [x] ~~Fix resource-timing/resource_TAO_multi_wildcard.html~~ (Doesn't work because IMG element doesn't generate HTTP request with Origin field) - [x] Fix /resource-timing/resource_TAO_match_origin.htm - [x] Fix /resource-timing/resource_TAO_match_wildcard.htm - [x] Fix /resource-timing/resource_TAO_multi.htm - [x] Fix /resource-timing/resource_TAO_wildcard.htm - [x] Fix /resource-timing/resource_TAO_zero.htm - [x] Fix /resource-timing/resource_TAO_null.htm - [x] Fix /resource-timing/resource_TAO_origin.htm (tests for responseStart and domainLookupEnd fail because #21260 and #21271 haven't been resolved) - [x] Fix /resource-timing/resource_TAO_space.htm - [x] Fix /resource-timing/resource_TAO_origin_uppercase.htm - [x] ~~Fix /resource-timing/resource_timing_TAO_cross_origin_redirect.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html) - [x] ~~Fix /resource-timing/TAO-case-insensitive-null-opaque-origin.sub.html~~ (TIMEOUT, doesn't seem to parse iFrame SRC correctly? There doesn't seem to be any sign that it makes a request to TAOResponse.py) - [x] Fix /resource-timing/TAO-crossorigin-port.sub.html - [x] ~~Fix /resource-timing/TAO-null-opaque-origin.sub.html~~ (Refer to /resource-timing/TAO-crossorigin-port.sub.html) - [x] /navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in.html - [x] /navigation-timing/nav2_test_document_open.html - [x] /navigation-timing/nav2_test_frame_removed.html - [x] /performance-timeline/not-clonable.html - [x] /navigation-timing/nav2_test_redirect_xserver.html - [x] /resource-timing/resource_connection_reuse.https.html - [x] /resource-timing/resource_reparenting.html - [x] /resource-timing/resource_connection_reuse.html - [x] /resource-timing/resource_script_types.html - [x] /resource-timing/idlharness.any.html - [x] /resource-timing/clear_resource_timing_functionality.html - [x] /resource-timing/idlharness.any.worker.html - [x] /resource-timing/resource_cached.htm - [x] /resource-timing/resource_connection_reuse_mixed_content_redirect.html - [x] /resource-timing/resource_connection_reuse_mixed_content.html - [x] /resource-timing/resource_timing_buffer_full_when_shrink_buffer_size.html - [x] /navigation-timing/idlharness.window.html - [x] /navigation-timing/nav2_test_navigate_iframe.html - [x] /navigation-timing/nav2_test_navigate_within_document.html - [x] /resource-timing/resource_reuse.sub.html - [x] /navigation-timing/nav2_test_instance_accessible_from_the_start.html - [x] /resource-timing/resource_dedicated_worker.html - [x] /navigation-timing/unload-event-same-origin-check.html - [x] /navigation-timing/nav2_test_navigation_type_backforward.html  - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23873)

bors-servo · 2019-09-25T00:15:46Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing e6b271d to master...

highfive assigned nox Jul 28, 2019

highfive added the S-awaiting-review label Jul 28, 2019

jdm assigned jdm and unassigned nox Aug 7, 2019

jdm added S-needs-code-changes and removed S-awaiting-review labels Aug 7, 2019

highfive added S-awaiting-review and removed S-needs-code-changes labels Aug 8, 2019

jdm added the S-needs-rebase label Aug 15, 2019

jdm requested changes Aug 15, 2019

View changes

jdm added S-needs-code-changes and removed S-awaiting-review labels Aug 15, 2019

highfive added S-awaiting-review and removed S-needs-code-changes labels Aug 19, 2019

jdm added S-needs-code-changes and removed S-awaiting-review labels Aug 21, 2019

highfive added S-awaiting-review and removed S-needs-code-changes labels Aug 22, 2019

RestitutorOrbis force-pushed the RestitutorOrbis:jn-add-tao branch from 605647c to 343a2db Sep 2, 2019

RestitutorOrbis force-pushed the RestitutorOrbis:jn-add-tao branch from 343a2db to 619946d Sep 4, 2019

jdm reviewed Sep 4, 2019

View changes

jdm added S-needs-code-changes and removed S-awaiting-review labels Sep 4, 2019

highfive removed the S-tests-failed label Sep 24, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Sep 24, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 24, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Sep 24, 2019

bors-servo merged commit 63adf66 into servo:master Sep 25, 2019
2 of 3 checks passed

2 of 3 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Sep 25, 2019

bors-servo mentioned this pull request Sep 25, 2019

Add secure connection start #23990

Merged

2 of 5 tasks complete

RestitutorOrbis mentioned this pull request Sep 26, 2019

Using history.back() on Window object of iFrame element doesn't trigger onload attr #24302

Open

CYBAI mentioned this pull request Feb 6, 2020

Intermittent pass in /html/semantics/embedded-content/the-img-element/srcset/avoid-reload-on-resize.html #24234

Open

servo / servo

Add PerformanceResourceTiming:TimingAllowCheck #23873

Add PerformanceResourceTiming:TimingAllowCheck #23873

RestitutorOrbis commented Jul 28, 2019 •

edited

highfive commented Jul 28, 2019

highfive commented Jul 28, 2019

highfive commented Jul 28, 2019

jdm commented Jul 29, 2019

RestitutorOrbis commented Jul 31, 2019 •

edited

jdm commented Aug 7, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

RestitutorOrbis commented Sep 3, 2019 •

edited

This comment has been minimized.

RestitutorOrbis commented Sep 24, 2019

bors-servo commented Sep 24, 2019

RestitutorOrbis commented Sep 24, 2019

bors-servo commented Sep 24, 2019

jdm commented Sep 24, 2019

bors-servo commented Sep 24, 2019

bors-servo commented Sep 24, 2019

jdm commented Sep 24, 2019

bors-servo commented Sep 24, 2019

bors-servo commented Sep 24, 2019

bors-servo commented Sep 24, 2019

jdm commented Sep 24, 2019

bors-servo commented Sep 24, 2019

bors-servo commented Sep 24, 2019

bors-servo commented Sep 25, 2019

servo / servo

Join GitHub today

Add PerformanceResourceTiming:TimingAllowCheck #23873

Add PerformanceResourceTiming:TimingAllowCheck #23873

Conversation

RestitutorOrbis commented Jul 28, 2019 • edited

Things to Do

highfive commented Jul 28, 2019

highfive commented Jul 28, 2019

highfive commented Jul 28, 2019

jdm commented Jul 29, 2019

RestitutorOrbis commented Jul 31, 2019 • edited

jdm commented Aug 7, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

RestitutorOrbis commented Sep 3, 2019 • edited

This comment has been minimized.

RestitutorOrbis commented Sep 24, 2019

bors-servo commented Sep 24, 2019

RestitutorOrbis commented Sep 24, 2019

bors-servo commented Sep 24, 2019

jdm commented Sep 24, 2019

bors-servo commented Sep 24, 2019

bors-servo commented Sep 24, 2019

jdm commented Sep 24, 2019

bors-servo commented Sep 24, 2019

bors-servo commented Sep 24, 2019

bors-servo commented Sep 24, 2019

jdm commented Sep 24, 2019

bors-servo commented Sep 24, 2019

bors-servo commented Sep 24, 2019

bors-servo commented Sep 25, 2019

RestitutorOrbis commented Jul 28, 2019 •

edited

RestitutorOrbis commented Jul 31, 2019 •

edited

RestitutorOrbis commented Sep 3, 2019 •

edited