Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "Replace use of callbacks in webxr by channels" #23874
Closed
Conversation
This backs out commit 133a17e / PR #23848 because it relies on a git branch that was apparently removed: ``` $ cargo fetch Updating git repository `https://github.com/asajeffrey/webxr` error: failed to resolve patches for `https://github.com/servo/webxr` Caused by: failed to load source for a dependency on `webxr` Caused by: Unable to update https://github.com/asajeffrey/webxr?branch=optional-glsync#da820a3a Caused by: revspec 'da820a3ab266fce07c9a8abee3e6e9231cb93ec5' not found; class=Reference (4); code=NotFound (-3) ```
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2019
Revert "Replace use of callbacks in webxr by channels" This backs out commit 133a17e / PR #23848 because it relies on a git branch that was apparently removed: ``` $ cargo fetch Updating git repository `https://github.com/asajeffrey/webxr` error: failed to resolve patches for `https://github.com/servo/webxr` Caused by: failed to load source for a dependency on `webxr` Caused by: Unable to update https://github.com/asajeffrey/webxr?branch=optional-glsync#da820a3a Caused by: revspec 'da820a3ab266fce07c9a8abee3e6e9231cb93ec5' not found; class=Reference (4); code=NotFound (-3) ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23874) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2019
Revert "Replace use of callbacks in webxr by channels" This backs out commit 133a17e / PR #23848 because it relies on a git branch that was apparently removed: ``` $ cargo fetch Updating git repository `https://github.com/asajeffrey/webxr` error: failed to resolve patches for `https://github.com/servo/webxr` Caused by: failed to load source for a dependency on `webxr` Caused by: Unable to update https://github.com/asajeffrey/webxr?branch=optional-glsync#da820a3a Caused by: revspec 'da820a3ab266fce07c9a8abee3e6e9231cb93ec5' not found; class=Reference (4); code=NotFound (-3) ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23874) <!-- Reviewable:end -->
|
@bors-servo r- |
|
This will be fixed by #23857. |
|
|
|
@bors-servo treeclosed- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedJul 28, 2019
•
edited
This backs out commit 133a17e / PR #23848 because it relies on a git branch that was apparently removed:
This change is