Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARM64 app startup #23878

Merged
merged 1 commit into from Jul 28, 2019
Merged

Fix ARM64 app startup #23878

merged 1 commit into from Jul 28, 2019

Conversation

@jdm
Copy link
Member

jdm commented Jul 28, 2019 •
edited by SimonSapin

I missed a DLL in the ARM64 app configuration, so currently it fails to start up. With this change I verified that https://joshmatthews.net/osc.html and https://joshmatthews.net/mp3.html produce audio output on a Windows arm64 laptop.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because no windows arm64 CI.

This change is Reviewable
@highfive
Copy link

highfive commented Jul 28, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/xrwebgllayer.rs, components/script/dom/xrsession.rs
  • @KiChjang: components/script/dom/xrwebgllayer.rs, components/script/dom/xrsession.rs
@jdm
Add missing GStreamer DLLs to ARM64 UWP app.
Loading status checks…
330706b
@jdm jdm force-pushed the jdm:gst-arm64 branch from 116a4bb to 330706b Jul 28, 2019
@jdm jdm added this to In progress in Windows ARM64 via automation Jul 28, 2019
@asajeffrey
asajeffrey approved these changes Jul 28, 2019
View changes
@asajeffrey
Copy link
Member

asajeffrey commented Jul 28, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2019

📌 Commit 330706b has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned SimonSapin Jul 28, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2019

⌛ Testing commit 330706b with merge 89bade4...
bors-servo added a commit that referenced this pull request Jul 28, 2019
@bors-servo
Auto merge of #23878 - jdm:gst-arm64, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
89bade4 
Fix ARM64 app startup

I missed a DLL in the ARM64 app configuration, so currently it fails to start up. With this change I verified that https://joshmatthews.net/osc.html and https://joshmatthews.net/mp3.html produce audio output on a Windows arm64 laptop.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because no windows arm64 CI.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23878)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing 89bade4 to master...
@bors-servo bors-servo merged commit 330706b into servo:master Jul 28, 2019
2 of 3 checks passed
2 of 3 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Windows ARM64 automation moved this from In progress to Done Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
Windows ARM64
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @asajeffrey @bors-servo @SimonSapin
You can’t perform that action at this time.