Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tasks instead of events #23900

Merged
merged 1 commit into from Aug 1, 2019
Merged

Use tasks instead of events #23900

merged 1 commit into from Aug 1, 2019
+19 −55

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Jul 31, 2019 •
edited by SimonSapin

This change is Reviewable
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 31, 2019

r? @jdm
@highfive highfive assigned jdm and unassigned Manishearth Jul 31, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 31, 2019 •
edited

Hmm, forgot to remove the Event type.

Fixed.
@paulrouget paulrouget force-pushed the paulrouget:tasks branch from 313f070 to 604ec69 Jul 31, 2019
@paulrouget
Use tasks instead of events
Loading status checks…
4525530
@paulrouget paulrouget force-pushed the paulrouget:tasks branch from 604ec69 to 4525530 Jul 31, 2019
@jdm
Copy link
Member

jdm commented Jul 31, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2019

📌 Commit 4525530 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2019

⌛ Testing commit 4525530 with merge c76de0a...
bors-servo added a commit that referenced this pull request Jul 31, 2019
@bors-servo
Auto merge of #23900 - paulrouget:tasks, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c76de0a 
Use tasks instead of events

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23900)
<!-- Reviewable:end -->
@paulrouget paulrouget mentioned this pull request Aug 1, 2019
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Aug 1, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2019

⌛ Testing commit 4525530 with merge 45af8a3...
bors-servo added a commit that referenced this pull request Aug 1, 2019
@bors-servo
Auto merge of #23900 - paulrouget:tasks, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
45af8a3 
Use tasks instead of events

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23900)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 45af8a3 to master...
@bors-servo bors-servo merged commit 4525530 into servo:master Aug 1, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@Darkspirit Darkspirit mentioned this pull request Aug 1, 2019
Closed
bors-servo added a commit that referenced this pull request Aug 5, 2019
@bors-servo
Auto merge of #23904 - paulrouget:loop2, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e76c880 
Better Hololens loop

Depends on #23900

Fix #23823

r? @gterzian

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23904)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 5, 2019
@bors-servo
Auto merge of #23904 - paulrouget:loop2, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a1a07f4 
Better Hololens loop

Depends on #23900

Fix #23823

r? @gterzian

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23904)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 7, 2019
@bors-servo
Auto merge of #23904 - paulrouget:loop2, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
371f514 
Better Hololens loop

Depends on #23900

Fix #23823

r? @gterzian

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23904)
<!-- Reviewable:end -->
@Manishearth
Manishearth reviewed Aug 9, 2019
View changes
support/hololens/ServoApp/BrowserPage.cpp
Event event = {{Event::SCROLL}};
event.scrollCoords = {dx, dy, x, y};
SendEventToServo(event);
RunOnGLThread([=] { mServo->Scroll(x, y, dx, dy); });

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Aug 9, 2019

Member

This should be dx, dy, x, y
@Manishearth Manishearth mentioned this pull request Aug 9, 2019
Merged
bors-servo added a commit that referenced this pull request Aug 10, 2019
@bors-servo
Auto merge of #23944 - Manishearth:hl-scroll, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5e2b88b 
Fix scrolling on hololens

This got inverted in #23900 by accident, mostly because the old code had two ordering mistakes that cancel each other out.

r? @jdm @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23944)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Aug 10, 2019
@bors-servo
Auto merge of #23944 - Manishearth:hl-scroll, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2af31be 
Fix scrolling on hololens

This got inverted in #23900 by accident, mostly because the old code had two ordering mistakes that cancel each other out.

r? @jdm @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23944)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@paulrouget @jdm @bors-servo @Manishearth @highfive
You can’t perform that action at this time.