Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webxr magicleap #23903

Merged
merged 1 commit into from Aug 2, 2019
Merged

Webxr magicleap #23903

merged 1 commit into from Aug 2, 2019

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jul 31, 2019 •
edited by SimonSapin

Adds the magicleap back end for webxr.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it's back end stuff

This change is Reviewable
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 31, 2019

The first commit is #23902.

The matching webxr PR is servo/webxr#35.
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 31, 2019

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned ferjm Jul 31, 2019
@Manishearth
Manishearth approved these changes Jul 31, 2019
View changes
Copy link
Member

Manishearth left a comment

let's land the webxr side first though
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-magicleap branch from 34af4bf to afbe777 Aug 1, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Aug 1, 2019

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2019

📌 Commit afbe777 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2019

⌛ Testing commit afbe777 with merge dd05c4c...
bors-servo added a commit that referenced this pull request Aug 1, 2019
@bors-servo
Auto merge of #23903 - asajeffrey:webxr-magicleap, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dd05c4c 
Webxr magicleap

<!-- Please describe your changes on the following line: -->

Adds the magicleap back end for webxr.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's back end stuff

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23903)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Aug 2, 2019

In android builds and linux tidy:

merror[E0063]: missing field `xr_discovery` in initializer of `simpleservo::InitOptions`
   --> ports/libsimpleservo/capi/src/lib.rs:136:16
    |
136 |     let opts = InitOptions {
    |                m^^^^^^^^^^^ mmissing `xr_discovery`

merror: aborting due to previous error

For more information about this error, try `rustc --explain E0063`.
error: Could not compile `simpleservo_capi`.
@asajeffrey
Added magicleap webxr back end
Loading status checks…
1ca495b
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-magicleap branch from afbe777 to 1ca495b Aug 2, 2019
@asajeffrey
Copy link
Member Author

asajeffrey commented Aug 2, 2019

Hopefully I fixed the android and c builds... @bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2019

📌 Commit 1ca495b has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2019

⌛ Testing commit 1ca495b with merge 3114af4...
bors-servo added a commit that referenced this pull request Aug 2, 2019
@bors-servo
Auto merge of #23903 - asajeffrey:webxr-magicleap, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3114af4 
Webxr magicleap

<!-- Please describe your changes on the following line: -->

Adds the magicleap back end for webxr.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's back end stuff

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23903)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2019

💔 Test failed - status-taskcluster
@asajeffrey
Copy link
Member Author

asajeffrey commented Aug 2, 2019

Hmm https://tools.taskcluster.net/groups/Zw7sMDqGQkec5wxBxQD58A/tasks/csyTNPCESimWHdoBKbLY7w/runs/0/logs/public%2Flogs%2Flive.log#L4746

[taskcluster:error] Uploading error artifact public/intermittents.log from file repo/intermittents.log with message "Could not read file '/Users/worker/tasks/task_1564771470/repo/intermittents.log'", reason "file-missing-on-worker" and expiry 2020-08-01T17:15:32.588Z

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2019

⌛ Testing commit 1ca495b with merge ecd3257...
bors-servo added a commit that referenced this pull request Aug 2, 2019
@bors-servo
Auto merge of #23903 - asajeffrey:webxr-magicleap, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ecd3257 
Webxr magicleap

<!-- Please describe your changes on the following line: -->

Adds the magicleap back end for webxr.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's back end stuff

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23903)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing ecd3257 to master...
@bors-servo bors-servo merged commit 1ca495b into servo:master Aug 2, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
A-xr-zomg
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@asajeffrey @bors-servo @CYBAI @Manishearth @ferjm @highfive
You can’t perform that action at this time.