Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix stylehsheet loader #23906

Closed
wants to merge 1 commit into from
Closed

[WIP] Fix stylehsheet loader #23906

wants to merge 1 commit into from

Conversation

@gterzian
Copy link
Member

gterzian commented Aug 1, 2019 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #23905 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable
@highfive
Copy link

highfive commented Aug 1, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/stylesheet_loader.rs
  • @KiChjang: components/script/stylesheet_loader.rs
@highfive
Copy link

highfive commented Aug 1, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@gterzian gterzian mentioned this pull request Aug 1, 2019
Open
@gterzian
expect on creation of ipc-channel in stylesheet loader
Loading status checks…
9cb6858
@gterzian gterzian force-pushed the gterzian:fix_stylesheet_loader branch from 6624919 to 9cb6858 Aug 1, 2019
@gterzian
Copy link
Member Author

gterzian commented Aug 1, 2019

non-issue
@gterzian gterzian closed this Aug 1, 2019
@gterzian gterzian deleted the gterzian:fix_stylesheet_loader branch Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

"Too many open files" crash after loading many small test cases via webdriver
3 participants
@gterzian @highfive @emilio
You can’t perform that action at this time.