Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix a panic when using layout 2020 #23920
Merged
+4
−2
Conversation
highfive
commented
Aug 6, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 6, 2019
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 6, 2019
Fix a panic when using layout 2020 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23920) <!-- Reviewable:end -->
|
|
|
That failure is #21067, but test-tidy fails: |
|
Oops, fixed. @bors-servo r=SimonSapin |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 6, 2019
Fix a panic when using layout 2020 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23920) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 6, 2019
Fix a panic when using layout 2020 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23920) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedAug 6, 2019
•
edited by SimonSapin
This change is