Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded gstreamer support to the magicleap port #23929
Merged
Conversation
highfive
commented
Aug 7, 2019
|
Heads up! This PR modifies the following files:
|
|
@bors-servo try=magicleap |
bors-servo
added a commit
that referenced
this pull request
Aug 7, 2019
Added gstreamer support to the magicleap port <!-- Please describe your changes on the following line: --> With this PR we can watch videos in magicleap servo. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because I'm not sure how we'd test it <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23929) <!-- Reviewable:end -->
|
|
|
Gstreamer needs the homebrew bison, not the system one. @bors-servo try=magicleap |
bors-servo
added a commit
that referenced
this pull request
Aug 7, 2019
Added gstreamer support to the magicleap port <!-- Please describe your changes on the following line: --> With this PR we can watch videos in magicleap servo. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because I'm not sure how we'd test it <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23929) <!-- Reviewable:end -->
|
|
|
Argh, it was still picking up the system bison, I suspect because the env isn't being passed through, including the custom |
bors-servo
added a commit
that referenced
this pull request
Aug 7, 2019
Added gstreamer support to the magicleap port <!-- Please describe your changes on the following line: --> With this PR we can watch videos in magicleap servo. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because I'm not sure how we'd test it <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23929) <!-- Reviewable:end -->
|
|
|
Well we got further this time... My guess is that the CFLAGS being set by mach and there ones being set by meson aren't playing well together. |
|
Ah, also the SDK version is |
|
Added the meson log file as a build artifact. @bors-servo try=magicleap |
bors-servo
added a commit
that referenced
this pull request
Aug 7, 2019
Added gstreamer support to the magicleap port <!-- Please describe your changes on the following line: --> With this PR we can watch videos in magicleap servo. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because I'm not sure how we'd test it <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23929) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 8, 2019
Added gstreamer support to the magicleap port <!-- Please describe your changes on the following line: --> With this PR we can watch videos in magicleap servo. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because I'm not sure how we'd test it <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23929) <!-- Reviewable:end -->
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Aug 8, 2019
Added gstreamer support to the magicleap port <!-- Please describe your changes on the following line: --> With this PR we can watch videos in magicleap servo. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because I'm not sure how we'd test it <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23929) <!-- Reviewable:end -->
|
|
|
I think that's #9087. @bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Aug 8, 2019
Added gstreamer support to the magicleap port <!-- Please describe your changes on the following line: --> With this PR we can watch videos in magicleap servo. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because I'm not sure how we'd test it <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23929) <!-- Reviewable:end -->
|
|
|
Hmm, that's #18655, but it's marked as closed? @bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Aug 9, 2019
Added gstreamer support to the magicleap port <!-- Please describe your changes on the following line: --> With this PR we can watch videos in magicleap servo. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because I'm not sure how we'd test it <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23929) <!-- Reviewable:end -->
|
The failure reported was actually: Not sure what you were looking at. |
|
|
This was referenced Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedAug 7, 2019
•
edited by SimonSapin
With this PR we can watch videos in magicleap servo.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is