Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TakeElementScreenshot WebDriver command #23943

Merged
merged 1 commit into from Aug 20, 2019
Merged

Implement TakeElementScreenshot WebDriver command #23943

merged 1 commit into from Aug 20, 2019
+134 −28

Conversation

@georgeroman
Copy link
Contributor

georgeroman commented Aug 9, 2019 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Aug 9, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/webdriver_handlers.rs, components/webdriver_server/lib.rs, components/constellation/constellation.rs, components/script/script_thread.rs, components/webdriver_server/Cargo.toml
  • @cbrewster: components/constellation/constellation.rs
  • @jgraham: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
  • @KiChjang: components/script/webdriver_handlers.rs, components/script/script_thread.rs, components/script_traits/webdriver_msg.rs, components/script_traits/lib.rs
@jdm
jdm reviewed Aug 10, 2019
View changes
...s/wpt/metadata/webdriver/tests/take_element_screenshot/screenshot.py.ini Show resolved Hide resolved
@jdm
Copy link
Member

jdm commented Aug 10, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2019

📌 Commit 33f5d29 has been approved by jdm
@jdm
Copy link
Member

jdm commented Aug 10, 2019

@bors-servo r-
@jdm
jdm reviewed Aug 10, 2019
View changes
components/compositing/compositor.rs Show resolved Hide resolved
@jdm
Copy link
Member

jdm commented Aug 10, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2019

📌 Commit ead5250 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2019

⌛ Testing commit ead5250 with merge 12c6b2a...
bors-servo added a commit that referenced this pull request Aug 10, 2019
@bors-servo
Auto merge of #23943 - georgeroman:implement_take_element_screenshot_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
12c6b2a 
…wd_command, r=jdm

Implement TakeElementScreenshot WebDriver command

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23943)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Aug 10, 2019 

error[E0609]: no field `id` on type `&webdriver::common::WebElement`
    --> components/webdriver_server/lib.rs:1520:77
     |
1520 |         let command = WebDriverScriptCommand::GetBoundingClientRect(element.id.clone(), sender);
     |                                                                             ^^

error: aborting due to previous error
@jdm
Copy link
Member

jdm commented Aug 15, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2019

📌 Commit 00511af has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 16, 2019

🔒 Merge conflict
@bors-servo
Copy link
Contributor

bors-servo commented Aug 16, 2019

☔ The latest upstream changes (presumably #23805) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2019

☔ The latest upstream changes (presumably #23838) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2019

☔ The latest upstream changes (presumably #23988) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
Copy link
Member

jdm commented Aug 18, 2019

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2019

✌️ @georgeroman can now approve this pull request
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

☔ The latest upstream changes (presumably #23951) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm jdm removed the S-awaiting-review label Aug 19, 2019
@georgeroman
Implement TakeElementScreenshot WebDriver command
Loading status checks…
d3696ba
@georgeroman
Copy link
Contributor Author

georgeroman commented Aug 19, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

📌 Commit d3696ba has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

⌛ Testing commit d3696ba with merge 171a082...
bors-servo added a commit that referenced this pull request Aug 19, 2019
@bors-servo
Auto merge of #23943 - georgeroman:implement_take_element_screenshot_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
171a082 
…wd_command, r=jdm

Implement TakeElementScreenshot WebDriver command

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23943)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 20, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 171a082 to master...
@bors-servo bors-servo merged commit d3696ba into servo:master Aug 20, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
This was referenced Aug 20, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@georgeroman @highfive @jdm @bors-servo
You can’t perform that action at this time.