Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling on hololens #23944

Merged
merged 1 commit into from Aug 10, 2019
Merged

Fix scrolling on hololens #23944

merged 1 commit into from Aug 10, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Aug 9, 2019

This got inverted in #23900 by accident, mostly because the old code had two ordering mistakes that cancel each other out.

r? @jdm @paulrouget


This change is Reviewable

@jdm
Copy link
Member

jdm commented Aug 10, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2019

📌 Commit 8686e74 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2019

Testing commit 8686e74 with merge 5e2b88b...

bors-servo added a commit that referenced this pull request Aug 10, 2019
Fix scrolling on hololens

This got inverted in #23900 by accident, mostly because the old code had two ordering mistakes that cancel each other out.

r? @jdm @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23944)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2019

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Aug 10, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2019

Testing commit 8686e74 with merge 2af31be...

bors-servo added a commit that referenced this pull request Aug 10, 2019
Fix scrolling on hololens

This got inverted in #23900 by accident, mostly because the old code had two ordering mistakes that cancel each other out.

r? @jdm @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23944)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 2af31be to master...

@bors-servo bors-servo merged commit 8686e74 into servo:master Aug 10, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.