Added support to download nuget and added python code to automate the…

[angelortiz1007]

… x64 and arm64 mach build -r/-d --uwp build process.

Modified/added python code to:

1. Download nuget which is required for building support\HoloLens
2. added python code to perform a nuget install/restore ServoApp.sln which causes the Angle libraries to be installed so that mach build will succeed.
3. added python code to perform a MsBuild of the support\HoloLens\ServoApp.sln solution so that mach build will build ServoApp and create a ServoApp .appx install file.

Note: The Msbuild path must be present otherwise the msbuild command will fail.

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #23753 (GitHub issue number if applicable)

• There are tests for these changes OR
• These changes do not require tests because by performing python mach build -r/-d --uwp ---win-arm64 or mach build -r/-d --uwp

---

This change is 

[angelortiz1007]

Important note.
When building, the msbuild.exe must be within the %PATH%.
If you open a x86_64 VS2017 command prompt msbuild will be found.

if you perform a cross platform build by opening a regular command prompt, you must set the path to where msbuild.exe is prior to:

1. set PKG_CONFIG_ALLOW_CROSS=1
2. python mach build -r --uwp --win-arm64

Here is an attempt to determine the msbuild.exe path at build time.
VSINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\

location of Msbuild.exe => MSBuild\15.0\Bin

VisualStudioVersion =15.0

set MSBUILDDIR=%VSINSTALLDIR%MsBuild%VisualStudioVersion%\bin

[nirbheek]

Here is an attempt to determine the msbuild.exe path at build time.

The approach used in GStreamer's Cerbero build system is to extract PATH from the environment set by vcvarsall.bat: https://gitlab.freedesktop.org/gstreamer/cerbero/blob/master/cerbero/ide/vs/env.py#L106

Might be worth trying to do the same in Servo too.

[angelortiz1007]

Here is an attempt to determine the msbuild.exe path at build time.

The approach used in GStreamer's Cerbero build system is to extract PATH from the environment set by vcvarsall.bat: https://gitlab.freedesktop.org/gstreamer/cerbero/blob/master/cerbero/ide/vs/env.py#L106
Might be worth trying to do the same in Servo too.

Thank you for looking at the pull request and providing this suggestion. I will review your suggestion!

Thank you,
Angel

[jdm]

Looks like a good start! I've left some comments for ways to make the code a bit more idiomatic and integrate better with the rest of the build system.

[jdm]

@bors-servo try=windows

[bors-servo]

⌛ Trying commit d28df22 with merge 55e471f...

[bors-servo]

💔 Test failed - status-taskcluster

[jdm]

@bors-servo retry

[bors-servo]

⌛ Trying commit d28df22 with merge 227ad85...

[angelortiz1007]

Implemented changes requested by JDM and performed the below tests. Rebased changes and performed a pull request for testing.

Ran tests to verify the following passed:

1. mach build -r/-d --uwp

2. python mach build -r --uwp --win-arm64

3. Tested return value from build_uwp_hololens() which calls check_call() by modifying msbuild parameter .\support\hololens\servoapp.sln to servoapp.sln2.
   Upon performing a build the logic introduced to set status = 1was tested. Output from test is shown below:
   MSBUILD : error MSB1009: Project file does not exist.
   Switch: .\support\hololens\servoapp.sln2
   Error running mach:

   ['build', '-r', '--uwp']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

CalledProcessError: Command 'm s b u i l d / m / p : p r o j e c t = S e r v o A p p . \ s u p p o r t \ h o l o l e n s \ s e r v o a p p . s l n 2 / p : S o l u t i o n D i r = . \ s u p p o r t \ h o l o l e n s / p : C o n f i g u r a t i o n = R e l e a s e / p : P l a t f o r m = x 6 4 / p : A p p x B u n d l e = A l w a y s ; A p p x B u n d l e P l a t f o r m s = x 6 4' returned non-zero exit status 1

File "C:\git-mozilla\angelortiz1007-2\python\servo\build_commands.py", line 702, in build
if build_uwp_hololens(target_triple, dev):
File "C:\git-mozilla\angelortiz1007-2\python\servo\build_commands.py", line 962, in build_uwp_hololens
check_call(msbuild_cmd + msbuild_conf)
File "C:\git-mozilla\angelortiz1007-2\python\servo\command_base.py", line 195, in check_call
raise subprocess.CalledProcessError(status, ' '.join(*args))

[jdm]

Instead of passing a single string, we should use a list:

check_call(["nuget", "restore", nuget_app])

[jdm]

@bors-servo try=windows

[bors-servo]

⌛ Trying commit cd6b048 with merge cad7e83...

[CYBAI]

Build started 8/22/2019 3:41:12 AM.
     1>Project "C:\Users\task_1566430230\repo\support\hololens\ServoApp.sln" on node 1 (default targets).
     1>ValidateSolutionConfiguration:
         Building solution configuration "Debug|x64".
     1>Project "C:\Users\task_1566430230\repo\support\hololens\ServoApp.sln" (1) is building "C:\Users\task_1566430230\repo\support\hololens\ServoApp\ServoApp.vcxproj" (2) on node 1 (default targets).
     2>C:\Users\task_1566430230\repo\support\hololens\ServoApp\ServoApp.vcxproj(323,5): error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\packages\Microsoft.Windows.CppWinRT.2.0.190620.2\build\native\Microsoft.Windows.CppWinRT.props.
     2>Done Building Project "C:\Users\task_1566430230\repo\support\hololens\ServoApp\ServoApp.vcxproj" (default targets) -- FAILED.
     1>Done Building Project "C:\Users\task_1566430230\repo\support\hololens\ServoApp.sln" (default targets) -- FAILED.

Build FAILED.

       "C:\Users\task_1566430230\repo\support\hololens\ServoApp.sln" (default target) (1) ->
       "C:\Users\task_1566430230\repo\support\hololens\ServoApp\ServoApp.vcxproj" (default target) (2) ->
       (EnsureNuGetPackageBuildImports target) -> 
         C:\Users\task_1566430230\repo\support\hololens\ServoApp\ServoApp.vcxproj(323,5): error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\packages\Microsoft.Windows.CppWinRT.2.0.190620.2\build\native\Microsoft.Windows.CppWinRT.props.

    0 Warning(s)
    1 Error(s)

[jdm]

@bors-servo try=windows

[bors-servo]

⌛ Trying commit 57adaaa with merge 0d7280a...

[bors-servo]

☀️ Test successful - status-taskcluster
State: approved= try=True

[jdm]

@bors-servo r+

[bors-servo]

📌 Commit 57adaaa has been approved by jdm

[bors-servo]

⌛ Testing commit 57adaaa with merge 382ebcc...

[bors-servo]

💔 Test failed - status-taskcluster

[jdm]

@bors-servo retry

[bors-servo]

💣 Failed to start rebuilding: Unknown error

[bors-servo]

⌛ Testing commit 57adaaa with merge ee9b3b3...

[bors-servo]

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing ee9b3b3 to master...