Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix build error when using the 'webgl_backtrace' feature #23966
Merged
Conversation
highfive
commented
Aug 14, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 14, 2019
|
|
|
r? @jdm |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 16, 2019
Fix build error when using the 'webgl_backtrace' feature This patch fixes a build error that happens when building with `--features webgl_backtrace`. However, while working on this I've noticed that calling `Backtrace::new()` instantly causes a segmentation fault. This didn't happen with the example code of [the package](https://crates.io/crates/backtrace) though, so I wasn't sure where to report this (maybe related: [backtrace-rs/#150](rust-lang/backtrace-rs#150), [backtrace-rs/#189](rust-lang/backtrace-rs#189)). cc @alexcrichton @jdm --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ - [x] These changes fix an issue that happens with a compile time feature not tested by the CI <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23966) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmatyas commentedAug 14, 2019
•
edited by SimonSapin
This patch fixes a build error that happens when building with
--features webgl_backtrace.However, while working on this I've noticed that calling
Backtrace::new()instantly causes a segmentation fault. This didn't happen with the example code of the package though, so I wasn't sure where to report this (maybe related: backtrace-rs/#150, backtrace-rs/#189).cc @alexcrichton @jdm
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is