[hololens] Handle servo panic #23983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
|
|
|
r? @jdm |
This was referenced Aug 19, 2019
Merged
jdm
approved these changes
Aug 19, 2019
|
This seems like a useful path forward. |
jdm
added
S-blocked-on-external
paulrouget
force-pushed
the
handlePanic
branch
from
f236cb2
to
449389f
Compare
highfive
added
the
S-awaiting-review
|
This needs a |
jdm
added
S-fails-tidy
paulrouget
force-pushed
the
handlePanic
branch
from
449389f
to
3933b43
Compare
highfive
added
the
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit 3933b43 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 21, 2019
[hololens] Handle servo panic Depends on #23981 Fix #23937 I've used a different approach than checking the return code of every single functions. Basically calling a C function on panic. That means the errors are not recoverable. I think it's fine for now. I'm open to any other better approach. @jdm what do you think? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23983) <!-- Reviewable:end -->
|
☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster |
bors-servo
pushed a commit
that referenced
this pull request
Aug 21, 2019
Do not leak the CAPI strings Depends on #23983 I haven't remove the mem::forget here: https://github.com/servo/servo/blob/6528c0d9b7b36fbdffc29bab99e0066b83a7f970/ports/libsimpleservo/capi/src/lib.rs#L228 What would be the right approach in that specific case? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23998) <!-- Reviewable:end -->
highfive
removed
the
S-awaiting-merge
This was referenced Aug 21, 2019
Merged
bors-servo
pushed a commit
that referenced
this pull request
Aug 22, 2019
Do not leak the CAPI strings Depends on #23983 I haven't remove the mem::forget here: https://github.com/servo/servo/blob/6528c0d9b7b36fbdffc29bab99e0066b83a7f970/ports/libsimpleservo/capi/src/lib.rs#L228 What would be the right approach in that specific case? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23998) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Aug 22, 2019
Missing C methods Depends on #23983 Fix #23969 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23999) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Aug 23, 2019
Missing C methods Depends on #23983 Fix #23969 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23999) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #23981
Fix #23937
I've used a different approach than checking the return code of every single functions.
Basically calling a C function on panic.
That means the errors are not recoverable. I think it's fine for now.
I'm open to any other better approach.
@jdm what do you think?
This change is