Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[hololens] Handle servo panic #23983
Merged
Conversation
highfive
commented
Aug 16, 2019
|
|
|
r? @jdm |
This was referenced Aug 19, 2019
Merged
|
This seems like a useful path forward. |
|
This needs a |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 21, 2019
[hololens] Handle servo panic Depends on #23981 Fix #23937 I've used a different approach than checking the return code of every single functions. Basically calling a C function on panic. That means the errors are not recoverable. I think it's fine for now. I'm open to any other better approach. @jdm what do you think? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23983) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 21, 2019
Do not leak the CAPI strings Depends on #23983 I haven't remove the mem::forget here: https://github.com/servo/servo/blob/6528c0d9b7b36fbdffc29bab99e0066b83a7f970/ports/libsimpleservo/capi/src/lib.rs#L228 What would be the right approach in that specific case? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23998) <!-- Reviewable:end -->
This was referenced Aug 21, 2019
Merged
bors-servo
added a commit
that referenced
this pull request
Aug 22, 2019
Do not leak the CAPI strings Depends on #23983 I haven't remove the mem::forget here: https://github.com/servo/servo/blob/6528c0d9b7b36fbdffc29bab99e0066b83a7f970/ports/libsimpleservo/capi/src/lib.rs#L228 What would be the right approach in that specific case? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23998) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Aug 22, 2019
Missing C methods Depends on #23983 Fix #23969 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23999) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Aug 23, 2019
Missing C methods Depends on #23983 Fix #23969 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23999) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedAug 16, 2019
•
edited by SimonSapin
Depends on #23981
Fix #23937
I've used a different approach than checking the return code of every single functions.
Basically calling a C function on panic.
That means the errors are not recoverable. I think it's fine for now.
I'm open to any other better approach.
@jdm what do you think?
This change is