Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.39.0-nightly (f7af19c27 2019-08-15) #23984

Merged
merged 3 commits into from Aug 23, 2019
Merged

Upgrade to rustc 1.39.0-nightly (f7af19c27 2019-08-15) #23984

merged 3 commits into from Aug 23, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Aug 16, 2019 •
edited

This change is Reviewable
@highfive
Copy link

highfive commented Aug 16, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/htmlinputelement.rs
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/htmlinputelement.rs
  • @emilio: components/style/stylesheets/viewport_rule.rs
@highfive
Copy link

highfive commented Aug 16, 2019

warning Warning warning

  • These commits modify style and script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Aug 16, 2019

Needs a mach fmt.
@jdm
jdm approved these changes Aug 16, 2019
View changes
@SimonSapin SimonSapin force-pushed the rustup branch from 052bf9e to dd9de57 Aug 16, 2019
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 16, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 16, 2019

📌 Commit dd9de57 has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Aug 16, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2019

☔ The latest upstream changes (presumably #23979) made this pull request unmergeable. Please resolve the merge conflicts.
@SimonSapin SimonSapin force-pushed the rustup branch from dd9de57 to 8004bce Aug 17, 2019
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 17, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2019

📌 Commit 8004bce has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2019

⌛ Testing commit 8004bce with merge f030c20...
bors-servo added a commit that referenced this pull request Aug 17, 2019
@bors-servo
Auto merge of #23984 - servo:rustup, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f030c20 
Upgrade to rustc 1.39.0-nightly (f7af19c27 2019-08-15)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23984)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Aug 22, 2019

Needs a mach fmt.
SimonSapin and others added 3 commits Aug 16, 2019
@SimonSapin
Upgrade to rustc 1.39.0-nightly (f7af19c27 2019-08-15)
98e4a53
@SimonSapin
Android glue: don’t zero-init non-null function pointers
2130e69 
Fixes:

```rust
error: the type `android_injected_glue::ffi::android_app` does not permit zero-initialization
   --> ports/libsimpleservo/jniapi/src/lib.rs:511:46
    |
511 |     let mut app: ffi::android_app = unsafe { std::mem::zeroed() };
    |                                              ^^^^^^^^^^^^^^^^^^
    |                                              |
    |                                              this code causes undefined behavior when executed
    |                                              help: use `MaybeUninit<T>` instead
    |
    = note: `-D invalid-value` implied by `-D warnings`
note: Function pointers must be non-null (in this struct field)
   --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/android_injected_glue-0.2.3/src/ffi.rs:23:5
    |
23  |     pub onAppCmd: extern fn(*mut android_app, i32),
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: aborting due to previous error
```
@jdm @SimonSapin
Update mozjs to support new UWP rustc targets.
Loading status checks…
203577c
@SimonSapin SimonSapin force-pushed the rustup branch from 0ead36b to 203577c Aug 23, 2019
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 23, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

📌 Commit 203577c has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

⌛ Testing commit 203577c with merge e57e51a...
bors-servo added a commit that referenced this pull request Aug 23, 2019
@bors-servo
Auto merge of #23984 - servo:rustup, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e57e51a 
Upgrade to rustc 1.39.0-nightly (f7af19c27 2019-08-15)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23984)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Aug 23, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

⌛ Testing commit 203577c with merge 5623ae4...
bors-servo added a commit that referenced this pull request Aug 23, 2019
@bors-servo
Auto merge of #23984 - servo:rustup, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5623ae4 
Upgrade to rustc 1.39.0-nightly (f7af19c27 2019-08-15)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23984)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Aug 23, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

⚡ Previous build results for linux-rel-wpt, status-taskcluster are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 5623ae4 to master...
@bors-servo bors-servo merged commit 203577c into master Aug 23, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @jdm @bors-servo @CYBAI @asajeffrey
You can’t perform that action at this time.