Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not leak the CAPI strings #23998
Merged
Do not leak the CAPI strings #23998
Conversation
highfive
commented
Aug 19, 2019
|
|
paulrouget
force-pushed the
paulrouget:rmForget
branch
2 times, most recently
from
1137aa1
to
b41e097
|
Any chance servo_version() can return a static string? The changes in this PR look fine to me. |
paulrouget
changed the title
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 21, 2019
Do not leak the CAPI strings Depends on #23983 I haven't remove the mem::forget here: https://github.com/servo/servo/blob/6528c0d9b7b36fbdffc29bab99e0066b83a7f970/ports/libsimpleservo/capi/src/lib.rs#L228 What would be the right approach in that specific case? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23998) <!-- Reviewable:end -->
|
|
|
Failed at |
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 22, 2019
Do not leak the CAPI strings Depends on #23983 I haven't remove the mem::forget here: https://github.com/servo/servo/blob/6528c0d9b7b36fbdffc29bab99e0066b83a7f970/ports/libsimpleservo/capi/src/lib.rs#L228 What would be the right approach in that specific case? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23998) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedAug 19, 2019
•
edited by SimonSapin
Depends on #23983
I haven't remove the mem::forget here:
servo/ports/libsimpleservo/capi/src/lib.rs
Line 228 in 6528c0d
What would be the right approach in that specific case?
This change is