Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing C methods #23999

Merged
merged 1 commit into from Aug 23, 2019
Merged

Missing C methods #23999

merged 1 commit into from Aug 23, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 19, 2019

Depends on #23983

Fix #23969


This change is Reviewable

@highfive
Copy link

highfive commented Aug 19, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@paulrouget paulrouget changed the title Missing C methods [WIP] Missing C methods Aug 19, 2019
@paulrouget paulrouget force-pushed the paulrouget:missingCMethods branch 2 times, most recently from 4f6fe69 to 86c46f3 Aug 20, 2019
@jdm
Copy link
Member

jdm commented Aug 21, 2019

Still WIP?

@paulrouget paulrouget changed the title [WIP] Missing C methods Missing C methods Aug 21, 2019
@paulrouget paulrouget force-pushed the paulrouget:missingCMethods branch from 86c46f3 to 82cf603 Aug 21, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2019

The latest upstream changes (presumably #24008) made this pull request unmergeable. Please resolve the merge conflicts.

@paulrouget paulrouget force-pushed the paulrouget:missingCMethods branch from 82cf603 to b642ff2 Aug 22, 2019
@jdm
Copy link
Member

jdm commented Aug 22, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2019

📌 Commit b642ff2 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2019

Testing commit b642ff2 with merge 7e19484...

bors-servo added a commit that referenced this pull request Aug 22, 2019
Missing C methods

Depends on #23983

Fix #23969

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23999)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

💔 Test failed - status-taskcluster

@CYBAI
Copy link
Collaborator

CYBAI commented Aug 23, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

Testing commit b642ff2 with merge 8672ab5...

bors-servo added a commit that referenced this pull request Aug 23, 2019
Missing C methods

Depends on #23983

Fix #23969

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23999)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 8672ab5 to master...

@bors-servo bors-servo merged commit b642ff2 into servo:master Aug 23, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.