Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update servo-media. Remove implicit shutdown requests. It all happens… #24000

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@ferjm
Copy link
Member

ferjm commented Aug 19, 2019

… automagicly now

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable

@ferjm ferjm mentioned this pull request Aug 19, 2019
4 of 5 tasks complete
@jdm
Copy link
Member

jdm commented Aug 19, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

📌 Commit 507a1e4 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

Testing commit 507a1e4 with merge c3679fb...

bors-servo added a commit that referenced this pull request Aug 19, 2019
Update servo-media. Remove implicit shutdown requests. It all happens…

… automagicly now

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24000)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

💔 Test failed - linux-rel-css

@ferjm
Copy link
Member Author

ferjm commented Aug 19, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

Testing commit 507a1e4 with merge 4f4c2be...

bors-servo added a commit that referenced this pull request Aug 19, 2019
Update servo-media. Remove implicit shutdown requests. It all happens…

… automagicly now

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24000)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 4f4c2be to master...

@bors-servo bors-servo merged commit 507a1e4 into servo:master Aug 19, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.