Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable GStreamer on Windows. #24004
Merged
Enable GStreamer on Windows. #24004
Conversation
|
r? @ferjm |
|
Manish says this prevents the UWP app from launching on the device, so don't merge it yet. |
|
|
|
I have verified that this does work on the device and on desktop, so I'm going to go ahead and merge this. |
|
r? @ferjm |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 27, 2019
Enable GStreamer on Windows. I have verified that desktop and emulator UWP builds work with this set of DLLs. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because no tests for UWP <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24004) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Aug 27, 2019
Enable GStreamer on Windows. I have verified that desktop and emulator UWP builds work with this set of DLLs. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because no tests for UWP <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24004) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedAug 19, 2019
•
edited by SimonSapin
I have verified that desktop and emulator UWP builds work with this set of DLLs.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is