Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate idna, log, mime, mime_guess, percent-encoding, unicase, url, ws #24006

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Aug 19, 2019

This change is Reviewable

@highfive
Copy link

highfive commented Aug 19, 2019

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/filemanager_thread.rs, components/net/fetch/methods.rs
@highfive
Copy link

highfive commented Aug 19, 2019

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Aug 19, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

📌 Commit 8eb650b has been approved by jdm

@highfive highfive assigned jdm and unassigned paulrouget Aug 19, 2019
bors-servo added a commit that referenced this pull request Aug 19, 2019
Deduplicate idna, log, mime, mime_guess, percent-encoding, unicase, url, ws

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24006)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

Testing commit 8eb650b with merge fb5a121...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing fb5a121 to master...

@bors-servo bors-servo merged commit 8eb650b into master Aug 19, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@atouchet atouchet mentioned this pull request Aug 19, 2019
16 of 19 tasks complete
@SimonSapin SimonSapin deleted the dedup branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.