Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hololens] Gesture capture #24013

Merged
merged 2 commits into from Aug 23, 2019
Merged

[hololens] Gesture capture #24013

merged 2 commits into from Aug 23, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 20, 2019 •
edited by SimonSapin

I can't reproduce #24010 but I think this should fix it.

Fix #24010

Depends on #24008

This change is Reviewable
@paulrouget paulrouget force-pushed the paulrouget:gestureCapture branch from 7753084 to 7d04cfc Aug 21, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 21, 2019

@Manishearth can you try this and tell me if the keyboard still shows up?
@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2019

☔ The latest upstream changes (presumably #23983) made this pull request unmergeable. Please resolve the merge conflicts.
paulrouget added 2 commits Aug 20, 2019
@paulrouget
Handle servo:// url
Loading status checks…
5c1d130
@paulrouget
Disable URL bar hit testing while scrolling in Servo
Loading status checks…
aaefaee
@paulrouget paulrouget force-pushed the paulrouget:gestureCapture branch from 7d04cfc to aaefaee Aug 21, 2019
@paulrouget paulrouget changed the title [WIP] [hololens] Gesture capture [hololens] Gesture capture Aug 21, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 21, 2019

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned nox Aug 21, 2019
@Manishearth
Copy link
Member

Manishearth commented Aug 21, 2019

Don't have a device on me until September, @jdm will though
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 22, 2019

I can reproduce the focus issue in the simulator. This PR solves the problem.
@jdm
Copy link
Member

jdm commented Aug 22, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2019

📌 Commit aaefaee has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Aug 22, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

⌛ Testing commit aaefaee with merge 5bf00c0...
bors-servo added a commit that referenced this pull request Aug 23, 2019
@bors-servo
Auto merge of #24013 - paulrouget:gestureCapture, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5bf00c0 
[hololens] Gesture capture

I can't reproduce #24010 but I think this should fix it.

Fix #24010

Depends on #24008

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24013)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 5bf00c0 to master...
@bors-servo bors-servo merged commit aaefaee into servo:master Aug 23, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced Aug 23, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

[hololens] manipulation events trigger clicks/focus on regular controls
6 participants
@paulrouget @bors-servo @Manishearth @jdm @nox @highfive
You can’t perform that action at this time.