Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow setting near/far clip planes #24018
Merged
Conversation
highfive
commented
Aug 20, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 20, 2019
|
|
|
You can r=me once webxr is updated, and the Cargo.lock file is regenerated. |
Manishearth
force-pushed the
Manishearth:wherever-you-are
branch
from
ebbb5d9
to
a5575da
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 23, 2019
Allow setting near/far clip planes needs servo/webxr#41 r? @asajeffrey <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24018) <!-- Reviewable:end -->
|
|
|
Needs a |
Manishearth
force-pushed the
Manishearth:wherever-you-are
branch
from
a5575da
to
0d79b2b
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 23, 2019
Allow setting near/far clip planes needs servo/webxr#41 r? @asajeffrey <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24018) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedAug 20, 2019
•
edited by SimonSapin
needs servo/webxr#41
r? @asajeffrey
This change is