Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync WPT with upstream (29-08-2019) #24100

Closed
wants to merge 2 commits into from
Closed

Sync WPT with upstream (29-08-2019) #24100

wants to merge 2 commits into from

Conversation

@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Aug 29, 2019 •
edited by SimonSapin

Automated downstream sync of changes from upstream as of 29-08-2019.
[no-wpt-sync]

This change is Reviewable
@servo-wpt-sync
Update web-platform-tests to revision 16ddb73a6251af3957efdbd6409b87a…
Loading status checks…
2bc82e8 
…9c8cf6e50
@servo-wpt-sync
Copy link
Collaborator Author

servo-wpt-sync commented Aug 29, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2019

📌 Commit 2bc82e8 has been approved by servo-wpt-sync
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2019

⌛ Testing commit 2bc82e8 with merge 8861689...
bors-servo added a commit that referenced this pull request Aug 29, 2019
@bors-servo
Auto merge of #24100 - servo-wpt-sync:wpt_update_29-08-2019, r=servo-…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8861689 
…wpt-sync

Sync WPT with upstream (29-08-2019)

Automated downstream sync of changes from upstream as of 29-08-2019.
[no-wpt-sync]
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2019

💔 Test failed - linux-rel-css
@CYBAI
Copy link
Collaborator

CYBAI commented Aug 29, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2019

⌛ Testing commit 2bc82e8 with merge a981267...
bors-servo added a commit that referenced this pull request Aug 29, 2019
@bors-servo
Auto merge of #24100 - servo-wpt-sync:wpt_update_29-08-2019, r=servo-…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a981267 
…wpt-sync

Sync WPT with upstream (29-08-2019)

Automated downstream sync of changes from upstream as of 29-08-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24100)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2019

💔 Test failed - linux-rel-css
@CYBAI
Copy link
Collaborator

CYBAI commented Aug 29, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2019

⌛ Testing commit 2bc82e8 with merge 880866b...
bors-servo added a commit that referenced this pull request Aug 29, 2019
@bors-servo
Auto merge of #24100 - servo-wpt-sync:wpt_update_29-08-2019, r=servo-…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
880866b 
…wpt-sync

Sync WPT with upstream (29-08-2019)

Automated downstream sync of changes from upstream as of 29-08-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24100)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2019

💔 Test failed - linux-rel-css
@CYBAI
CYBAI reviewed Aug 29, 2019
View changes
tests/wpt/metadata/css/CSS2/selectors/first-letter-punctuation-341.xht.ini Outdated
@@ -1,3 +1,3 @@
[first-letter-punctuation-341.xht]
type: reftest
expected: FAIL
expected: TIMEOUT

This comment has been minimized.

Sign in to view
Copy link
@CYBAI

CYBAI Aug 29, 2019 •
edited

Collaborator

Hmm, this is third time 🤔 I wonder if it might not need to be updated as TIMEOUT?

{
    "status": "FAIL", 
    "group": "default", 
    "message": "/css/CSS2/selectors/first-letter-punctuation-341.xht 07bd1ae84c8390ac3e1d662deeaeef2c5a7f392b\n/css/CSS2/selectors/first-letter-punctuation-341-ref.xht 732b170530b51aab0fe1c83a60a8b82dbf7a22c8", 
    "stack": null, 
    "subtest": null, 
    "test": "/css/CSS2/selectors/first-letter-punctuation-341.xht", 
    "line": 83028, 
    "action": "test_result", 
    "expected": "TIMEOUT"
}

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Aug 29, 2019

Member

Yep, probably an intermittent issue.
@jdm
Remove intermittent timeout.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c0dac75
@jdm
Copy link
Member

jdm commented Aug 29, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2019

📌 Commit c0dac75 has been approved by jdm
@highfive highfive assigned jdm and unassigned servo-wpt-sync Aug 29, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2019

⌛ Testing commit c0dac75 with merge ee55429...
bors-servo added a commit that referenced this pull request Aug 29, 2019
@bors-servo
Auto merge of #24100 - servo-wpt-sync:wpt_update_29-08-2019, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ee55429 
Sync WPT with upstream (29-08-2019)

Automated downstream sync of changes from upstream as of 29-08-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24100)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 29, 2019

💔 Test failed - linux-rel-wpt
@CYBAI
Copy link
Collaborator

CYBAI commented Aug 30, 2019

Another intermittent

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/CSS2/syntax/at-rule-002.xht", 
    "line": 53354, 
    "action": "test_result", 
    "expected": "FAIL"
}
@CYBAI
Copy link
Collaborator

CYBAI commented Aug 30, 2019

Close in favor of #24113
@CYBAI CYBAI closed this Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

@CYBAI CYBAI

Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@servo-wpt-sync @bors-servo @CYBAI @jdm @SimonSapin @highfive
You can’t perform that action at this time.